Skip to content

Flix's CLI surface has changed upstream #1

Description

@github-actions

flixw parses flix --help to decide which verbs reach the compiler. Upstream's parser definition no longer matches the fingerprint committed at tests/upstream/flix-cli.fingerprint.

upstream-cli: Flix's CLI surface has changed at flix/flix@master

@@ -1,5 +1,8 @@
 arg File <file>...
 arg Int port
+cmd - Xmemory
+cmd - Xperf
+cmd - Xzhegalkin
 cmd - build
 cmd - build-classes
 cmd - build-fatjar
@@ -19,20 +22,12 @@
 cmd - repl
 cmd - run
 cmd - test
-cmd - Xmemory
-cmd - Xperf
-cmd - Xzhegalkin
 opt Int listen
 opt Int n
 opt Int threads
 opt LibLevel Xlib
 opt String entrypoint
 opt String github-token
-opt Unit frontend
-opt Unit json
-opt Unit no-install
-opt Unit par
-opt Unit top
 opt Unit Xbenchmark-code-size
 opt Unit Xbenchmark-frontend
 opt Unit Xbenchmark-incremental
@@ -42,4 +37,9 @@
 opt Unit Xno-deprecated
 opt Unit Xprint-phases
 opt Unit Xsummary
+opt Unit frontend
+opt Unit json
+opt Unit no-install
+opt Unit par
+opt Unit top
 opt Unit yes

What to check, in this order:
  1. tests/UnitCheck.java -- does parseVerbs still find every command in the new set?
  2. BUILTIN_VERBS in src/stage0/flixw.java -- it is the fallback when a parse fails,
     and a verb missing from it is a verb flixw silently will not route.
  3. src/assets/flixw-help.java -- a new option *kind* changes what a completion must mark -r.
  4. Adopt with: sh tests/upstream-cli.sh --update

This is a notice, not a build failure: flixw still works, because an unparseable or unfamiliar help screen falls back to BUILTIN_VERBS. What it loses is any verb the fallback does not name. Run sh tests/upstream-cli.sh locally for the same output.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions