chore(release): set release_always back to false - #2372
Merged
Conversation
`true` was a one-push recovery for v0.42.0 (#2371), not the steady state: it makes every merge that lands after a release PR part of that release, unreviewed and unchangelogged. The comment records how to recover next time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the one-push recovery switch from #2371 now that it has done its job.
release_always = truepublishes on any push whose manifest version is ahead of crates.io — right for recovering the stranded v0.42.0, wrong as the steady state: every merge that lands after a release PR becomes part of that release, unreviewed and without a changelog entry. Back tofalse(publish only from a release-PR merge commit); the comment inrelease-plz.tomlrecords the recovery recipe for next time.Merge only after v0.42.0 is confirmed on crates.io (
curl -s https://index.crates.io/ri/g-/rig-core | tail -1→ 0.42.0, and thev0.42.0tag exists). The in-progress cd run for #2371 reads the setting from its own checkout, so this PR cannot interfere with it — but if that publish were to fail,falsewould strand the release again.