feat: compact four-state Repair Panel with real cooperative cancellation - #182
feat: compact four-state Repair Panel with real cooperative cancellation#182JG2547 wants to merge 2 commits into
Conversation
Operator-authored redesign (applied from patch; GitHub integration hit a 403 on branch creation). Compact centered wizard: Checking → Ready to fix Zoom → Fixing Zoom (Step 1–4 + progress) → You're all set / Open Zoom. Dynamic installed version (no hardcoded v5.5.1). Diagnostics, recovery, updater, feedback, support kept via progressive disclosure. Adds a REAL Cancel fix path (not Exit-as-cancel): src/main/fix-cancel.js cooperative broker routes cancellation through the existing quit-app IPC while run-fix is active (no new IPC surface); cancellation stops only at known-safe stage boundaries and never interrupts the atomic account/profile rebuild. Cancelling… / Fix cancelled states; Exit-during-fix offers Keep running / Cancel fix and exit. New smoke suites fix-cancel-smoke + compact-shell-smoke wired into npm test. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Applies the operator-specified CODEOWNERS content verbatim. Two defects fixed: 1. @high-texas (id 124146493) is an empty third-party account, not an org member, with no collaborator access anywhere in the estate. GitHub silently ignores CODEOWNERS entries for users without write access, so all 9 entries naming it have been inert since written. Replaced with @JG2547 (admin). 2. There was no default rule, so any path outside the 9 listed patterns had NO code owner at all -- which is why PR #182 has no requested reviewer. Adds '* @JG2547 @patricktobias86'. Does not weaken require_code_owner_review, required_approving_review_count, require_last_push_approval, or require_extra_approval_for_unattributed_changes. No access was granted to @high-texas.
|
Designated Repair Panel survivor. #181 is superseded by this PR and will be closed once its capture capability is preserved in a separate tooling-only PR. I verified the supersession against branch contents rather than PR descriptions. This PR independently reaches #181's intended geometry:
Same 560px, same centring, same "only an inner pane scrolls, never the window" rule — reached by injecting CSS over the existing shell instead of editing One gap to close before #181 can be closed: Tracked as L-08 / L-09 in Not merging this myself — flagging it as the survivor and leaving the merge decision with you. |
3 participants
Operator-authored redesign, applied from a patch against `main` HEAD `6881f490` (the operator's connected GitHub integration returned 403 on branch creation, so this was applied + tested + pushed via CLI).
What changes
v5.5.1).Cancel fix(not Exit-as-cancel):src/main/fix-cancel.jscooperative broker routes cancellation through the existingquit-appIPC whilerun-fixis active — no new IPC surface. Cancellation stops only at known-safe stage boundaries and never interrupts the atomic account/profile rebuild (satisfies the repo's existing cancellation requirement).Cancelling…/Fix cancelledstates; Exit-during-fix offersKeep running/Cancel fix and exit.Tests
npm testfull suite PASS (includes newtools/fix-cancel-smoke.js+tools/compact-shell-smoke.js).node --checkclean on all new/changed JS.Relationship to #181
#181 (
feat/repair-panel-redesign) is a prior harness-built single-centered-card redesign. This PR is the operator's independent compact four-state approach with real cooperative cancellation and is likely intended to supersede #181 — maintainers should pick one and close the other rather than merging both.🤖 Generated with Claude Code