Release 2026.08.20 - #174
Merged
Merged
Conversation
…ort (#168) * fix(search): implement geo_type=proximity and fix taxonomy distance sort geo_type=proximity was documented in the DTO/Swagger but had no implementation - it fell through to the same "service_area contains AND geo_distance" logic as the default, silently ignoring the caller's request for radius-only search. Add the missing branch: when geo_type=proximity, skip the geo_shape service_area containment filter and apply only the geo_distance radius filter. Also fix the default sort for query_type=taxonomy: when sort is unset (relevance default) and coords are provided, sort by geo-distance instead of service_at_location_id.raw (a UUID). The Norse UI already advertises "Nearest First" as its default without sending an explicit sort param, so this makes the API's default match what's already promised. Falls back to the previous UUID tie-breaker when no coords are given. Fixes ISS-1182. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * style: trim comments, keep code self-documenting Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * docs(swagger): document geo_type on /search, add missing @apiquery geo_type was a real, validated field on SearchResourcesQueryDto but had no @apiquery decorator on either the GET or POST /search handler, so it never appeared in the rendered Swagger docs at all - unlike every other query param on this endpoint, which is explicitly documented. Add the missing @apiquery to both handlers, describing what each geo_type value actually does (including the default's AND semantics this PR fixes) and that boundary requires a POST body. Also add a description to the DTO's own @ApiPropertyOptional for consistency, and clarify that distance only takes effect alongside coords. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
* chore: expand AGENTS.md docs and refresh skills setup * fix format * remove copilot instructions
u11d-michal-miler
self-requested a review
August 20, 2026 09:28
u11d-michal-miler
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.