Harden vavd CLI, admin, and web pairing UX - #29
Open
Obooman wants to merge 3 commits into
Open
Conversation
Extract a shared argv parser so invalid ports and unknown flags fail loudly, print a new pairing URI from rotate-offer, fall back when the admin socket is stale, and let the web UI and vav CLI cancel, reply, and paste a vav-daemon:// line. Co-authored-by: Oboo Cheng <oboochin@gmail.com>
Help, version, and admin verbs no longer import node-pty, and phone-client tests destroy hung sockets so the suite cannot stall on server.close. Co-authored-by: Oboo Cheng <oboochin@gmail.com>
Obooman
marked this pull request as ready for review
September 5, 2026 13:13
Keep the thin vavd CLI, Host 421 checks, spawn timeout kill, and CLI cancel/reply work. Take main's phone-ui + discover stack for the web page and Chrome side panel instead of the old inline pairing UI. Co-authored-by: Oboo Cheng <oboochin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge
main(through 1.19.1 / Chrome discover + phone-ui) into this branch.What this PR still does
Headless vavd CLI/admin/spawn hardening on top of main’s phone-ui +
/discoverstack:vavdrejects invalid--port/--web-port/ unknown flags;--version,--quiet,--flag=valuework.--help/--version/ admin verbs do not loadnode-pty.vavd rotate-offeragainst a running daemon prints the new pairing URI. A staleadmin.jsonfalls back to disk.vavcancancelandreply, reports cancelled turns, and says when vavd is not listening instead of dumpingECONNREFUSED.Hostheaders with 421.waitForPairingis exported and still returns{ pairing, stdout }so desktop can readwebOrigin.Merge conflict notes
Simple (combined both sides): changelog, READMEs, thin
vavd.ts+ lazy serve, spawn timeout +webOrigin, Host 421 +/discover/ phone-ui assets, both spawn tests.Conflicting UI architecture (took main):
webUi.ts,extension/sidepanel.html,extension/sidepanel.js. Main replaced the inline pairing-paste UI with shared phone-ui + MV3 discover. Keeping our HTML/JS would regress #28 / #31 / #32.Test plan
/discover+ 421 on bad Host