Skip to content

fix(tests): browser_bindings no-such-table in agent-mode protocol tests - #8

Merged
2233admin merged 1 commit into
mainfrom
fix/browser-bindings-test-db-session
Jul 9, 2026
Merged

fix(tests): browser_bindings no-such-table in agent-mode protocol tests#8
2233admin merged 1 commit into
mainfrom
fix/browser-bindings-test-db-session

Conversation

@2233admin

Copy link
Copy Markdown
Owner

两测试没patch backend.database.AsyncSessionLocal,导致真查未迁移DB报no such table: browser_bindings。main分支已连续多次CI因此挂红。照同文件其他agent-mode测试的写法补patch。

test_collect_agent_mode_ws_protocol_not_implemented and
test_collect_agent_mode_unknown_protocol didn't patch
backend.database.AsyncSessionLocal like the sibling tests in this file,
so collect()'s agent-endpoint resolution hit the real (unmigrated) DB
and failed with 'no such table: browser_bindings'. Wire them to the
db_engine fixture the same way test_health_check_* already does.
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@2233admin, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 49 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e0432dd8-dc00-4970-b93c-420bfafe8900

📥 Commits

Reviewing files that changed from the base of the PR and between a98dda4 and 87ea319.

📒 Files selected for processing (1)
  • tests/unit/channels/test_opencli_channel.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@repowise-bot

repowise-bot Bot commented Jul 9, 2026

Copy link
Copy Markdown

✅ Health: 9.2

📋 At a glance
1 hotspot touched · 4 co-change pairs left out. Scoped to tests.

🔎 More signals (2)

🔥 Hotspot touched (1)

  • .../channels/test_opencli_channel.py — 3 commits/90d, 0 dependents · primary owner: xujinghua (100%)

🔗 Hidden coupling (1 file)

  • .../channels/test_opencli_channel.py co-changes with these files (not in this PR):
    • backend/agent_server.py (2× — 🟢 routine)
    • backend/channels/opencli_channel.py (2× — 🟢 routine)
    • tests/unit/test_ws_agent_manager.py (2× — 🟢 routine)
    • tests/unit/test_workers_api.py (2× — 🟢 routine)

👀 Suggested reviewers @xujinghua


📊 Full report · ⭐ Star Repowise · 📥 Install bot · Last updated 2026-07-09 22:30 UTC
Silence on a single PR with [skip repowise] in the title · Per-repo toggle on repowise.dev/settings?tab=bot

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the unit tests test_collect_agent_mode_ws_protocol_not_implemented and test_collect_agent_mode_unknown_protocol in tests/unit/channels/test_opencli_channel.py to accept the db_engine fixture and patch backend.database.AsyncSessionLocal with _sessionmaker(db_engine). There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@2233admin
2233admin merged commit 8612c7a into main Jul 9, 2026
5 checks passed
@2233admin
2233admin deleted the fix/browser-bindings-test-db-session branch July 9, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant