fix(tests): browser_bindings no-such-table in agent-mode protocol tests - #8
Conversation
test_collect_agent_mode_ws_protocol_not_implemented and test_collect_agent_mode_unknown_protocol didn't patch backend.database.AsyncSessionLocal like the sibling tests in this file, so collect()'s agent-endpoint resolution hit the real (unmigrated) DB and failed with 'no such table: browser_bindings'. Wire them to the db_engine fixture the same way test_health_check_* already does.
|
Warning Review limit reached
Next review available in: 49 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Health: 9.2 📋 At a glance 🔎 More signals (2)🔥 Hotspot touched (1)
🔗 Hidden coupling (1 file)
👀 Suggested reviewers @xujinghua 📊 Full report · ⭐ Star Repowise · 📥 Install bot · Last updated 2026-07-09 22:30 UTC |
There was a problem hiding this comment.
Code Review
This pull request updates the unit tests test_collect_agent_mode_ws_protocol_not_implemented and test_collect_agent_mode_unknown_protocol in tests/unit/channels/test_opencli_channel.py to accept the db_engine fixture and patch backend.database.AsyncSessionLocal with _sessionmaker(db_engine). There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
两测试没patch backend.database.AsyncSessionLocal,导致真查未迁移DB报no such table: browser_bindings。main分支已连续多次CI因此挂红。照同文件其他agent-mode测试的写法补patch。