fix: map AxeOS VR temp to board, chip temp to chain#315
Open
adamdecaf wants to merge 1 commit into
Open
Conversation
adamdecaf
force-pushed
the
fix/bitaxe-nerdaxe-asic-vr-temps
branch
2 times, most recently
from
July 17, 2026 19:53
c531ffe to
9432ec5
Compare
b-rowan
requested changes
Jul 17, 2026
b-rowan
left a comment
b-rowan
left a comment
Member
There was a problem hiding this comment.
Concept ACK, but I think this should be limited to fixes specifically on the relevant miner types, and not touch the core data structures (other than the small documentation changed mentioned if you feel it's required).
adamdecaf
force-pushed
the
fix/bitaxe-nerdaxe-asic-vr-temps
branch
from
July 17, 2026 20:25
9432ec5 to
261e1c5
Compare
adamdecaf
changed the title
Author
|
That's my bad. Changing core types wasn't my intention - was going a bit too fast with Grok. |
adamdecaf
force-pushed
the
fix/bitaxe-nerdaxe-asic-vr-temps
branch
from
July 17, 2026 20:42
261e1c5 to
8679ba7
Compare
adamdecaf
changed the title
Member
|
Still a couple core changes, just revert them fully. Making average be chip OR board is even more confusing... |
AxeOS exposes distinct sensors on /api/system/info: `temp` (ASIC chip) and `vrTemp` (voltage regulator / board). Bitaxe and Nerdaxe backends copied `vrTemp` into inlet/outlet chip temperatures and often left `chips[].temperature` empty by reading `temp` from the config-only /api/system/asic payload. Map `vrTemp` to board_temperature and `temp` to inlet/outlet plus chips[0].temperature, preferring live system/info over the ASIC config endpoint.
adamdecaf
force-pushed
the
fix/bitaxe-nerdaxe-asic-vr-temps
branch
from
July 17, 2026 22:29
8679ba7 to
2904f28
Compare
adamdecaf
changed the title
b-rowan
requested changes
Jul 20, 2026
b-rowan
left a comment
b-rowan
left a comment
Member
There was a problem hiding this comment.
One more small thing I noticed, other than that this should be good.
Comment on lines
+315
to
+325
| // Always emit a chip row when we have live telemetry; temperature comes | ||
| // from system/info `temp`, not the config-only ASIC endpoint. | ||
| board.chips = vec![ChipData { | ||
| position: 0, | ||
| temperature: chip_temp, | ||
| voltage: board.voltage, | ||
| frequency: board.frequency, | ||
| tuned: Some(true), | ||
| working: Some(true), | ||
| hashrate: board.hashrate.clone(), | ||
| }]; |
Member
There was a problem hiding this comment.
I believe the reason the check for chip data was here is for guarding for DataField::Chips, since having that check will skip adding the chips if it is excluded by the user.
Suggested change
| // Always emit a chip row when we have live telemetry; temperature comes | |
| // from system/info `temp`, not the config-only ASIC endpoint. | |
| board.chips = vec![ChipData { | |
| position: 0, | |
| temperature: chip_temp, | |
| voltage: board.voltage, | |
| frequency: board.frequency, | |
| tuned: Some(true), | |
| working: Some(true), | |
| hashrate: board.hashrate.clone(), | |
| }]; | |
| if let Some(chip_data) = chip_data { | |
| board.chips = vec![ChipData { | |
| position: 0, | |
| temperature: chip_temp, | |
| voltage: board.voltage, | |
| frequency: board.frequency, | |
| tuned: Some(true), | |
| working: Some(true), | |
| hashrate: board.hashrate.clone(), | |
| }]; | |
| } |
Comment on lines
+621
to
+655
| assert_eq!(hashboards_without_chips[0].chips.len(), 1); | ||
| assert_eq!(hashboards_without_chips[0].working_chips, Some(1)); | ||
| assert_eq!( | ||
| hashboards_without_chips[0].chips[0] | ||
| .temperature | ||
| .map(|t| t.as_celsius()), | ||
| Some(59.875) | ||
| ); | ||
| assert_eq!( | ||
| hashboards_without_chips[0] | ||
| .board_temperature | ||
| .map(|t| t.as_celsius()), | ||
| Some(78.0) | ||
| ); | ||
| assert_eq!( | ||
| hashboards_without_chips[0] | ||
| .inlet_chip_temperature | ||
| .map(|t| t.as_celsius()), | ||
| Some(59.875) | ||
| ); | ||
| assert_eq!( | ||
| hashboards_without_chips[0] | ||
| .outlet_chip_temperature | ||
| .map(|t| t.as_celsius()), | ||
| Some(59.875) | ||
| ); | ||
| // Guard against the old bug that copied VR into chip-chain fields. | ||
| assert_ne!( | ||
| hashboards_without_chips[0] | ||
| .board_temperature | ||
| .map(|t| t.as_celsius()), | ||
| hashboards_without_chips[0] | ||
| .inlet_chip_temperature | ||
| .map(|t| t.as_celsius()) | ||
| ); |
Member
There was a problem hiding this comment.
Can revert these test changes with the fix above, these should have no chips since they should be explicitly excluded by the user.
Comment on lines
+312
to
+320
| board.chips = vec![ChipData { | ||
| position: 0, | ||
| temperature: chip_temp, | ||
| voltage: board.voltage, | ||
| frequency: board.frequency, | ||
| tuned: Some(true), | ||
| working: Some(true), | ||
| hashrate: board.hashrate.clone(), | ||
| }]; |
Member
There was a problem hiding this comment.
Save thing here, can re-add the check.
Suggested change
| board.chips = vec![ChipData { | |
| position: 0, | |
| temperature: chip_temp, | |
| voltage: board.voltage, | |
| frequency: board.frequency, | |
| tuned: Some(true), | |
| working: Some(true), | |
| hashrate: board.hashrate.clone(), | |
| }]; | |
| if let Some(chip_data) = chip_data { | |
| board.chips = vec![ChipData { | |
| position: 0, | |
| temperature: chip_temp, | |
| voltage: board.voltage, | |
| frequency: board.frequency, | |
| tuned: Some(true), | |
| working: Some(true), | |
| hashrate: board.hashrate.clone(), | |
| }]; | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AxeOS exposes distinct sensors on /api/system/info:
temp(ASIC chip) andvrTemp(voltage regulator / board). Bitaxe and Nerdaxe backends copiedvrTempinto inlet/outlet chip temperatures and often leftchips[].temperatureempty by readingtempfrom the config-only /api/system/asic payload.Map
vrTempto board_temperature andtempto inlet/outlet plus chips[0].temperature, preferring live system/info over the ASIC config endpoint.