Conversation
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A BLOCK INV currently refreshes peer activity before the block is validated. Record receipt-time eligibility and confirm that activity only after the matching block is successfully processed through the broadcast or sync path. Use the recorded receipt time and a monotonic updater; advertisers receive no block-provider contribution credit.
Keep pending receipts in a per-peer cache capped at 100 entries with one-minute expiration, clear it on disconnect, and coordinate registration and confirmation with one lock.
Why?
Unverified announcements should not keep a peer active, while honest advertisers should receive activity credit even when another peer supplies the block.
Split scope
Independent split 2 of #91, based directly on
release_v4.8.3. Confirmation hooks use the release branch's existing successful-processing paths and check shutdown directly, so this PR does not depend on the provider-accounting PR (#97). After that PR merges, reconcile the overlapping handler hooks and use the monotonic updater for its new provider activity sites; inject a mockAdvServiceinto the provider-accounting sync test fixture. Download scheduling and retry/recovery are separate changes.Existing APIs remain available; added APIs are Java 8 compatible. No wire/storage formats, dependencies, or configuration change.
Validation
checkstyleMain checkstyleTestpassed.test: 3,470 tests, 26 skipped, zero failures/errors.:framework:generateGitPropertiesbecause the existing metadata plugin cannot resolve linked worktrees.Related split PRs
All three target
release_v4.8.3independently. The fourth retry/recovery PR will be proposed only after these three merge.