Conversation
3kyro
commented
Nov 4, 2025
3kyro
commented
Owner
- Upgraded Rust toolchain from 1.90.0 to 1.91.0 (latest stable as of 2025-10-30)
- Updated crossterm dependency from 0.23.2 to 0.28 for latest terminal handling features
- Updated regex dependency from 1.5.5 to 1.11 for improved performance and features
- Code review confirms full compatibility with Rust 2021 edition and latest compiler
- No breaking changes detected in source code
- Upgraded Rust toolchain from 1.90.0 to 1.91.0 (latest stable as of 2025-10-30) - Updated crossterm dependency from 0.23.2 to 0.28 for latest terminal handling features - Updated regex dependency from 1.5.5 to 1.11 for improved performance and features - Code review confirms full compatibility with Rust 2021 edition and latest compiler - No breaking changes detected in source code
The crossterm library introduced breaking changes in version 0.25+ that require updating KeyEvent pattern matching: - Import KeyEventKind to handle new event structure - Add kind: KeyEventKind::Press filter to all KeyEvent patterns - This prevents duplicate events on Windows (Press/Release) - Ensures compatibility with crossterm 0.28's keyboard enhancement protocol Breaking changes addressed: - KeyEvent now includes 'kind' and 'state' fields - Must filter for Press events to avoid registering events twice - Maintains backward compatibility with existing functionality
Resolved multiple clippy warnings to pass strict CI lint checks: 1. clippy::new_without_default - Added #[derive(Default)] to Autocomplete struct - Simplified new() to use Self::default() 2. clippy::ptr_arg - Changed get_common() return type: &String -> &str - Changed get_keywords() return type: &Vec<String> -> &[String] 3. clippy::redundant_clone - Removed unnecessary clone: keyword.clone().trim_end() -> keyword.trim_end() - Optimized buffer handling: buffer.clone().pop() -> buffer.chars().last() 4. clippy::unnecessary_unwrap / clippy::if_let_some_result - Replaced is_some() + unwrap() pattern with proper if let Some bindings - Improved readability and safety in exec_valid_char() 5. clippy::question_mark / clippy::unnecessary_wraps - Simplified if-let-Some-else pattern to unwrap_or_default() All changes maintain existing functionality while improving code quality and performance.
Changed exec_command to take &str instead of String since it only needs to read the value for comparison, not take ownership.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.