Skip to content
This repository was archived by the owner on May 11, 2021. It is now read-only.

update to camden - #612

Open
mariuszs wants to merge 1 commit into
masterfrom
tech/update_to_camden
Open

update to camden#612
mariuszs wants to merge 1 commit into
masterfrom
tech/update_to_camden

Conversation

@mariuszs

Copy link
Copy Markdown
Collaborator

No description provided.

@mariuszs
mariuszs requested review from maciekpe, szpak and twroniak March 31, 2017 12:53
@mariuszs mariuszs self-assigned this Mar 31, 2017
@szpak

szpak commented Mar 31, 2017

Copy link
Copy Markdown
Collaborator

Caused by: org.gradle.internal.service.UnknownServiceException: No service of type StyledTextOutputFactory available in ProjectScopeServices.

@szpak

szpak commented Mar 31, 2017

Copy link
Copy Markdown
Collaborator

AFAIR the new Axion is required to use with newer Gradle version (due to changes in Gradle)

@SpringApplicationConfiguration(value = TestApplication.class, initializers = ConfigFileApplicationContextInitializer.class)
@IntegrationTest("com.ofg.infra.microservice.track-activity.enabled = false")
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.NONE, classes = TestApplication.class,
value = "com.ofg.infra.microservice.track-activity.enabled = false")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RunWith(SpringJUnit4ClassRunner.class)
@SpringApplicationConfiguration(value = TestApplication.class, initializers = ConfigFileApplicationContextInitializer.class)
@ContextConfiguration(classes = TestApplication.class,
initializers = ConfigFileApplicationContextInitializer.class)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why in two lines?

Comment thread build.gradle
dependency "org.objenesis:objenesis:2.5.1"

dependencySet(group:'org.spockframework', version: '1.0-groovy-2.4') {
dependencySet(group:'org.spockframework', version: '1.1-groovy-2.4-rc-4') {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread micro-deps/build.gradle Outdated
testCompile "org.springframework.boot:spring-boot-starter-actuator"
testCompile "org.springframework.boot:spring-boot-starter-jersey"
testCompile "org.springframework.boot:spring-boot-starter-tomcat"
testCompile "org.springframework.boot:spring-boot-starter-jetty"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

*/
@CompileStatic
@WebAppConfiguration
//@WebAppConfiguration

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm?

@Value('${stubrunner.use-microservice-definitions:false}') boolean useMicroserviceDefinitions,
@Value('${stubrunner.wait-for-service:false}') boolean waitForService,
@Value('${stubrunner.wait-timeout:1}') Integer waitTimeout,
@Value('${stubrunner.wa`it-timeout:1}') Integer waitTimeout,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure with that change?

@Value('${stubrunner.stubs.classifier:}') String stubsClassifier,
@Value('${stubrunner.work-offline:false}') boolean workOffline,
@Deprecated @Value('${stubrunner.skip-local-repo:true}') boolean skipLocalRepo,
@Deprecated @Value('${stubrunnbatchStubRunnerer.skip-local-repo:true}') boolean skipLocalRepo,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice name :)

@mariuszs
mariuszs force-pushed the tech/update_to_camden branch 5 times, most recently from fac41db to 2d997aa Compare March 31, 2017 18:38
@mariuszs
mariuszs force-pushed the tech/update_to_camden branch from 2d997aa to 32ce342 Compare April 3, 2017 08:08

@szpak szpak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If fixed acceptance tests

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants