Derive the weapon qual sort order from the award catalog

[SyniRon]

This was generated by AI during triage.

Behavior

Adding a weapon qual takes three edits that must agree by hand. The catalog gets the titles and a tag. WeaponQual.weaponOrder gets that same tag in its SOP slot. The plate PNG gets the tag as its filename.

Nothing ties the slot edit to the catalog edit. Forget the slot and the weapon sorts last on the bar. No test fails. That is how the Recoilless Rifle bug in #229 happened, and the Mk-82 tests from #227 cannot see the same mistake for the last weapon in the SOP.

After this change, one edit adds a weapon. The SOP order lives with the catalog, and the sort reads it from there. A weapon qual tag with no order fails a test instead of sorting last.

What a member sees on the uniform does not change. Every weapon stacks where the SOP puts it, same as today.

[SyniRon]

This was generated by AI during triage.

Agent Brief

Category: enhancement
Summary: Weapon qual plates sort by an awardPriority on their catalog entries. The hand-written slot list in WeaponQual goes.

Start condition:
This brief builds on PR #241 (Mk-82), which is still in review. Do not wait for it. Branch from the head of #241, claude/triage-227-needs-info-9d25ad, and open the PR with that branch as its base, so the diff shows only this change. If #241 has merged by the time you start, branch from main and target main instead. Either way the catalog must hold "Mk-82 Expert" before you begin. If it does not, stop and report.

Current behavior:
WeaponQual keeps a list of weapon qual tags in SOP order and sorts each level array (expertQuals, sharpshooterQuals, marksmanQuals) by a tag's index in that list. A tag the list does not know gets index -1 and sorts last.

The catalog entries for weapon quals carry awardTag and awardType and nothing about order. So a new weapon takes three edits that must agree by hand: the catalog entries, the slot in the list, and the plate file named after the tag. The plate file has a test. The slot does not.

The canvas tests cover part of the gap. Every weapon in the catalog gets a row that checks it stacks above the last SOP weapon, so a missing or misspelled slot for a mid-SOP weapon fails two tests. Verified on main: dropping recoilless from the list fails two tests. The last SOP weapon is the blind spot. Dropping hydra70 from the list passes all 34 tests, because last is where the SOP puts it. The test file says so in its own comment. #241 moves that blind spot to mk82.

Ribbons, unit citations, medals and tabs already sort by awardPriority read from their catalog entries. Weapon quals are the one ordered type that does not.

Desired behavior:
Every weapon qual entry in the catalog carries a numeric awardPriority, the weapon's rank in the S1 Uniforms SOP weapon order. All three entries for one tag carry the same number. Lower sorts first, the same way ribbons and tabs read it.

The SOP order the catalog must encode, first to last:

1. rifle
2. grenade
3. tankWeapons
4. m203
5. machineGun
6. recoilless
7. pistol
8. aeroweapons
9. hydra70
10. mk82

The SOP lists Carbine and Auto Rifle between Aeroweapons and Hydra 70. Neither has a catalog entry. Leave a gap in the numbers for them or do not. Only the relative order matters.

WeaponQual sorts each level array by that priority and no longer holds an order list of its own. The three level arrays keep their shape, arrays of tag strings, because the canvas builds the plate path from the tag. Nothing a member sees changes. Every plate draws where it drew before.

A weapon qual entry with no priority fails a catalog test, the same way an entry with no plate file fails one today. That closes the last-weapon blind spot for good, so the per-weapon "stacks above the last weapon" rows and their count guard go. The reverse-SOP-order test stays and grows to hold all ten weapons. It is the one place the SOP is typed by hand, so a wrong number in the catalog fails there.

Key interfaces:

• Catalog weapon qual entries: new awardPriority field, a number. The registry hands the whole catalog entry back from getAwardDetails, so WeaponQual.addAward already has the priority in reach when it files a tag. No registry change.
• WeaponQual: the order list and the indexOf sort go. Sorting reads the priority. How the class keeps tag-to-priority in hand is the agent's call, as long as the level arrays stay arrays of tags.
• Catalog test, beside the plate-file rows, driven by the real AWARD_CATALOG: every entry of type WeaponQual has a numeric awardPriority; entries that share a tag share one priority; no two tags share a priority.
• Canvas test: the reverse-SOP test lists all ten Expert quals in reverse SOP order and expects the ten tags in SOP order, typed by hand from the list above. The "stacks above" family, its count guard and its comment block are removed.

Acceptance criteria:

• Every WeaponQual entry in the catalog has a numeric awardPriority. Removing one from any entry fails a catalog test.
• Entries that share an awardTag share one awardPriority. Giving one of the three Pistol entries a different number fails a catalog test.
• No two tags share an awardPriority. Giving Pistol the same number as Rifle fails a catalog test. Dropped at implementation. The tie fails the reverse-SOP canvas test instead, because the held list is reversed and a stable sort keeps a tied pair reversed. A guard beside that test reads the catalog for which weapons exist, so the next weapon cannot land without a place in the list, and a copied priority on it fails there too. A catalog row would be a structural copy that cannot go red alone.
• All ten Expert quals, added in reverse SOP order, yield expertQuals equal to ["rifle", "grenade", "tankWeapons", "m203", "machineGun", "recoilless", "pistol", "aeroweapons", "hydra70", "mk82"]. Swapping any two priorities in the catalog fails this test.
• WeaponQual contains no hand-written list of weapon tags.
• The existing level-filing tests (Mk-82 Expert under expertQuals, and so on) pass unchanged.
• npm test and npm run format:check pass. Both run in CI.

Out of scope:

• Adding Carbine, Auto Rifle or any other weapon to the catalog.
• Changing the SOP position of any weapon.
• Plate art, plate geometry, weaponQualPlatePath or the plate-file test.
• How ribbons, medals, unit citations or tabs use awardPriority.
• Any change to what the canvas draws.