Copy review follow-up for #305 - #306
Merged
Merged
Conversation
panel/hubs.go: replace "Choose a voice channel of the guild." panel/templates/home.html: delete the page description under the Hubs title panel/templates/home.html: revise "not in the guild" to "not in the server" panel/templates/home.html: replace the empty-list row panel/templates/home.html: replace the Voice channel hint panel/templates/home.html: revise the Base string hint to name Cavbot2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the copy decisions from the review of #305. Copy only; no behavior change.
panel/hubs.go: the stale-picker refusal now reads "That channel is no longer a voice channel in the server. Choose another."panel/templates/home.html: the description line under the Hubs title is gone.panel/templates/home.html: a hub whose channel is gone shows "not in the server".panel/templates/home.html: the empty list reads "No hubs yet. Register a voice channel below."panel/templates/home.html: the Voice channel hint reads "Channels that are already hubs are hidden."panel/templates/home.html: the Base string hint reads "Cavbot2 names spawned channels from it: "Arma Voice" gives "Arma Voice - 1"."CI gate run locally: lint,
go test ./...with Postgres, coverage floors, build. All pass.