Skip to content

#3089 generate populateMany method for explicit_requires#3115

Draft
MikhailLipanin wants to merge 1 commit into
99designs:masterfrom
MikhailLipanin:issue-#3089/federation_plugin
Draft

#3089 generate populateMany method for explicit_requires#3115
MikhailLipanin wants to merge 1 commit into
99designs:masterfrom
MikhailLipanin:issue-#3089/federation_plugin

Conversation

@MikhailLipanin

Copy link
Copy Markdown

Describe your PR and link to any relevant issues.

Closes #3089

continuation of #2884

In this Pull Request, I've added generation of PopulateMany... methods for slice of entities - if the explicit_requires option enabled, and an @entityResolver(multi: true).

Right now, it generates stub federation.requires.go, that does nothing.

@jesse-apollo, I will be very glad to receive your suggestions for this task :)

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@MikhailLipanin
MikhailLipanin marked this pull request as draft June 2, 2024 21:09
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 74.77% (+0.05%) from 74.72%
when pulling 3a065fa on MikhailLipanin:issue-#3089/federation_plugin
into e07134a on 99designs:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

proposal: Federation plugin: combination of explicit_requires with entity multi-resolver works as not expected

2 participants