fix: guard experimental React transition APIs - #509
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: theg1239 <theg1239@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
The installed React runtime does not export
ViewTransitionoraddTransitionType, but multiple app components imported and rendered/called those APIs directly. A page that renders the shared directional transition boundary or course-paper grid can crash on render, and programmatic search/filter/navigation interactions can throw when clicked/submitted.Root cause
Recent view-transition code trusted canary TypeScript declarations/docs, but the actual
react@19.2.8package in this lockfile still reports both experimental exports as absent.Fix
OptionalViewTransitionto render children whenReact.ViewTransitionis unavailable.addReactTransitionTypeto no-op safely whenReact.addTransitionTypeis unavailable.scripts/test-react-transition-compat.tsxto lock in the fallback behavior.Validation
node --input-type=modulenamed import check confirmedViewTransitionis absent in the installed React package.pnpm exec tsx scripts/test-react-transition-compat.tsxpassed.pnpm exec tsx scripts/test-hydration-recovery-privacy.ts && pnpm exec tsx scripts/test-global-error-reload-guard.ts && pnpm exec tsx scripts/test-inline-youtube-watchdog.tspassed.pnpm --filter examcooker typecheckpassed.pnpm buildcompiled successfully and passed TypeScript, then stopped at expected local page-data collection becauseDATABASE_URLis not set.