DLC-APPLY (afi-core): retire the silent 24h decay default - #34
Merged
Conversation
DEFAULT_SIGNAL_HALF_LIFE_HOURS is deleted; applyTimeDecayToUwrScore and applyVolatilityAdjustedDecay now require the half-life explicitly — a parameter the caller never chose is never quietly substituted. The hour-unit wrapper is re-documented as superseded for production use by the canonical minutes-based applyTimeDecay (src/decay, KAT-bound to the governed 32-vector apply-time-decay KAT). ValidatorDecision (the sole, dormant caller — always explicit args) carries the conformance note; the adjusted-half-life family stays unwired per D-DLC-3(4). Tests updated to pass explicit half-lives. 303 green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Kilo Code Review could not run — your account is out of credits. Add credits or switch to a free model to enable reviews on this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DLC-GOV
DLC-APPLYslot — afi-core half (D-DLC-3(2))Authorized by DLC-GOV (accepted
4a91928, 37th decision; slot authorization recorded in the Status flip,cd1ca14).DEFAULT_SIGNAL_HALF_LIFE_HOURSdeleted;applyTimeDecayToUwrScore/applyVolatilityAdjustedDecayrequire the half-life explicitly. The silent fallback is now structurally unreachable from every path — production or otherwise.applyTimeDecay(src/decay, already bit-exact against the governed 32-vector KAT) per D-DLC-1.ValidatorDecision.ts(sole caller, dormant, afi-mint-only consumer): conformance note — it always passed explicit parameters; the adjusted-half-life family remains expressly unwired (D-DLC-3(4)).Gate: zero movement in any sealed byte, hash, golden, or KAT (this PR touches none); suite 303 green; typecheck clean.
🤖 Generated with Claude Code