Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation addresses non-contiguous CPU IDs; the remaining regression-test request is a minor nit.
Review effort: Lite
Findings: None
What changed in this PR
Fixes --cores all to use actual CPU IDs from the process affinity mask, including non-contiguous allocations.
Changes:
- Uses
get_core_ids()instead of sequential IDs. - Supports cgroup and container CPU constraints.
| File | Summary |
|---|---|
crates/core_affinity2/src/lib.rs |
Uses affinity-derived CPU IDs for all. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
--cores allto use the actual CPU IDs returned by the system affinity mask instead of assuming that CPU IDs are consecutive starting from zero.This is important when the process is restricted to a non-contiguous set of CPUs, for example
1,3,7. The same issue can occur when CPU resources are limited through Linux cgroups or container CPU constraints.Checklist
./scripts/precommit.shand addressed all comments