Skip to content

Fix test_scan_layers_mismatch_tpu layer path assertion#4602

Draft
hsuan-lun-chiang wants to merge 1 commit into
mainfrom
fix/scan_layers_mismatch_assertion
Draft

Fix test_scan_layers_mismatch_tpu layer path assertion#4602
hsuan-lun-chiang wants to merge 1 commit into
mainfrom
fix/scan_layers_mismatch_assertion

Conversation

@hsuan-lun-chiang

@hsuan-lun-chiang hsuan-lun-chiang commented Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Fix layer path assertion in test_scan_layers_mismatch_tpu from decoder/layers/0/ to decoder/layers_0/ to align with the unscanned layer naming structure refactored in PR #4504.

Test

Error Log
Fix

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@gemini-code-assist

gemini-code-assist Bot commented Jul 24, 2026

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@hsuan-lun-chiang
Fix test_scan_layers_mismatch_tpu layer path assertion
7b8cebf 
Update layer path assertion in test_scan_layers_mismatch_tpu from
decoder/layers/0/ to decoder/layers_0/ to match the unscanned layer
naming structure introduced in PR #4504.
@hsuan-lun-chiang
hsuan-lun-chiang force-pushed the fix/scan_layers_mismatch_assertion branch from a9cdfae to 7b8cebf Compare July 24, 2026 11:21
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinavclemson abhinavclemson Awaiting requested review from abhinavclemson abhinavclemson will be requested when the pull request is marked ready for review abhinavclemson is a code owner
@gobbleturk gobbleturk Awaiting requested review from gobbleturk gobbleturk will be requested when the pull request is marked ready for review gobbleturk is a code owner
@khatwanimohit khatwanimohit Awaiting requested review from khatwanimohit khatwanimohit will be requested when the pull request is marked ready for review khatwanimohit is a code owner
@bvandermoon bvandermoon Awaiting requested review from bvandermoon bvandermoon will be requested when the pull request is marked ready for review bvandermoon is a code owner
@vipannalla vipannalla Awaiting requested review from vipannalla vipannalla will be requested when the pull request is marked ready for review vipannalla is a code owner
@RissyRan RissyRan Awaiting requested review from RissyRan RissyRan will be requested when the pull request is marked ready for review RissyRan is a code owner
@richjames0 richjames0 Awaiting requested review from richjames0 richjames0 will be requested when the pull request is marked ready for review richjames0 is a code owner
@gagika gagika Awaiting requested review from gagika gagika will be requested when the pull request is marked ready for review gagika is a code owner
@shralex shralex Awaiting requested review from shralex shralex will be requested when the pull request is marked ready for review shralex is a code owner
@SurbhiJainUSC SurbhiJainUSC Awaiting requested review from SurbhiJainUSC SurbhiJainUSC will be requested when the pull request is marked ready for review SurbhiJainUSC is a code owner
@hengtaoguo hengtaoguo Awaiting requested review from hengtaoguo hengtaoguo will be requested when the pull request is marked ready for review hengtaoguo is a code owner
@A9isha A9isha Awaiting requested review from A9isha A9isha will be requested when the pull request is marked ready for review A9isha is a code owner
@aireenmei aireenmei Awaiting requested review from aireenmei aireenmei will be requested when the pull request is marked ready for review aireenmei is a code owner
@NuojCheng NuojCheng Awaiting requested review from NuojCheng NuojCheng will be requested when the pull request is marked ready for review NuojCheng is a code owner
@jiangjy1982 jiangjy1982 Awaiting requested review from jiangjy1982 jiangjy1982 will be requested when the pull request is marked ready for review jiangjy1982 is a code owner
@suexu1025 suexu1025 Awaiting requested review from suexu1025 suexu1025 will be requested when the pull request is marked ready for review suexu1025 is a code owner
@dipannita08 dipannita08 Awaiting requested review from dipannita08 dipannita08 will be requested when the pull request is marked ready for review dipannita08 is a code owner
@igorts-git igorts-git Awaiting requested review from igorts-git igorts-git will be requested when the pull request is marked ready for review igorts-git is a code owner
@darisoy darisoy Awaiting requested review from darisoy darisoy will be requested when the pull request is marked ready for review darisoy is a code owner
@xibinliu xibinliu Awaiting requested review from xibinliu xibinliu will be requested when the pull request is marked ready for review xibinliu is a code owner
@huytransformer huytransformer Awaiting requested review from huytransformer huytransformer will be requested when the pull request is marked ready for review huytransformer is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hsuan-lun-chiang