Skip to content

fix: add support for more ArrayLike data types - #407

Merged
JessUWE merged 9 commits into
mainfrom
rfixes
Aug 25, 2026
Merged

fix: add support for more ArrayLike data types#407
JessUWE merged 9 commits into
mainfrom
rfixes

Conversation

@jim-smith

Copy link
Copy Markdown
Contributor

Adds support for more ArrayLike data types to be passed to crosstab and pivot tables
addresses issues with R interface
Resolves #406

@jim-smith jim-smith added the enhancement New feature or request label Aug 21, 2026
@jim-smith

Copy link
Copy Markdown
Contributor Author

needs checking with a different install of R, preferably on a windows machine

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.86%. Comparing base (fe729ae) to head (408d821).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
+ Coverage   99.81%   99.86%   +0.05%     
==========================================
  Files          15       15              
  Lines        2107     2172      +65     
==========================================
+ Hits         2103     2169      +66     
+ Misses          4        3       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jim-smith

Copy link
Copy Markdown
Contributor Author

@JessUWE this should fix the R issue - does on my Mac, do you have a set-up that can replicate Maha's tests?

@JessUWE JessUWE changed the title [fix] adding support for more ArrayLike data types addressing issues #406 fix: add support for more ArrayLike data types Aug 25, 2026
@JessUWE

JessUWE commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

@JessUWE this should fix the R issue - does on my Mac, do you have a set-up that can replicate Maha's tests?

@jim-smith it still gives me errors, this is my steps to testing it

  1. Created the virtual env
  2. installed the current acro version
  3. ran the acro r notebook(Maha gave me) in the virtual env (inst/notebooks/acro_demo_2026.R)

it gives me the below error
image

@JessUWE
JessUWE merged commit fb594d7 into main Aug 25, 2026
5 checks passed
@JessUWE
JessUWE deleted the rfixes branch August 25, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Add support for more ArrayLike data types in acro tables

2 participants