CI: Report SBML simulation and sensitivity checks independently - #3254
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3254 +/- ##
==========================================
- Coverage 78.57% 78.55% -0.02%
==========================================
Files 318 318
Lines 22248 22248
Branches 1491 1491
==========================================
- Hits 17482 17478 -4
- Misses 4758 4762 +4
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Split test_sbml_testsuite_case into separate simulation and sensitivity test nodes, sharing one session-scoped fixture so the model is still compiled only once per case. A case whose simulation is correct but whose sensitivities aren't (yet) checkable no longer gets misreported as an overall failure/skip. Requires --dist=loadgroup wherever this suite runs with -n, so both nodes for a case stay on the same xdist worker -- otherwise they will import the model twice and race on the same on-disk model directory. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dweindl
force-pushed
the
backport-sbml-split-reporting
branch
from
September 8, 2026 04:29
5b9adc0 to
9315a83
Compare
dweindl
marked this pull request as ready for review
September 8, 2026 05:37
FFroehlich
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparation for #3253:
Split
test_sbml_testsuite_caseinto separate simulation and sensitivity test nodes, sharing one session-scoped model setup fixture so the model is still compiled only once per case. This enables separately skipping/reporting the sensitivity check results.Requires
--dist=loadgroupwherever this suite runs with-n, so both nodes for a case stay on the same xdist worker -- otherwise they will import the model twice and race on the same on-disk model directory.