feat(withdraw): ZK-073 redesign relayer binding and zero-relayer semantics - #458
Draft
s6pa1rta3n-lab wants to merge 1 commit into
Draft
feat(withdraw): ZK-073 redesign relayer binding and zero-relayer semantics#458s6pa1rta3n-lab wants to merge 1 commit into
s6pa1rta3n-lab wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wave Issue Key: ZK-073
Resolves #349
Redesigns relayer binding and zero-relayer semantics across Noir circuits, SDK, and Soroban smart contracts:
Nonein SDK and encoded as canonical0x0032-byte field element with fee=0.circuits/lib/src/validation/relayer.nrenforces that zero relayer requires zero fee, and non-zero fee requires non-zero relayer.validate_relayer_and_feein Soroban contract rejects malformed relayers and inconsistent fee structures.Verification
nargo check --workspace&nargo test --package withdraw(35/35 tests pass).npm run build&npm test(57/57 suites pass, 860/860 tests pass).cargo test(93/93 tests pass).node scripts/zk_ticket_check.mjs --issue-key ZK-073 --run(all derived ticket checks passed).Payout Routing
0xF46C9F6d70C50BF81ef3588AB523a90a594a2F89GCL6OXAMLD75BMTINA6EMRUDWK5THQUSHMYNLSNBCJAPZJHNYJTUNIBC