Skip to content

Fixed references to a v3 directory that no longer exists in the repo - #665

Closed
mjiori wants to merge 1 commit into
masterfrom
v3-references-fix
Closed

Fixed references to a v3 directory that no longer exists in the repo#665
mjiori wants to merge 1 commit into
masterfrom
v3-references-fix

Conversation

@mjiori

@mjiori mjiori commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

This PR fixes up references to a v3 directory that no longer exists in this repo, preventing code from building.
I also added a note to DevelopingDART about running wails build before testing and fixed up some list numbers.

All tests pass.

…and fixed up lists and added context to DevelopingDART documentation
@mjiori
mjiori requested a review from diamondap August 5, 2026 15:28
@mjiori mjiori mentioned this pull request Aug 5, 2026
@diamondap

diamondap commented Aug 5, 2026

Copy link
Copy Markdown
Member

I can't approve these changes. v3 is actually the package version number, not a folder name. If you look in go.mod, you'll see the name of the package is module github.com/APTrust/dart/v3. You'll also see we include Wails v2 as github.com/wailsapp/wails/v2 v2.10.2 and Minio as github.com/minio/minio-go/v7. We reference those packages the same way when we include them in go files, as we do for Minio at

"github.com/minio/minio-go/v7/pkg/credentials"
.

I want to keep the current package version. I'm not sure why you can't run the tests without these changes. They run on Mac, Linux and Windows for me. Is there some other problem with your setup?

@mjiori

mjiori commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

My bad, I was working under a mistaken assumption.

I got the tests to work without these changes. The real solution for me was to run:
go get github.com/APTrust/dart/v3/dart
go get github.com/APTrust/dart/v3/server

I'll add this to the documentation, and I will close this PR and open a new one to do that.

@mjiori mjiori closed this Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants