Skip to content

Feat: Add B_PER_10 to UEFI execution #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chetan-rathore merged 1 commit into from
Aug 26, 2026
Merged

Feat: Add B_PER_10 to UEFI execution #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/uefi/acs_helpers.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1215,9 +1215,10 @@ createDmaInfoTable(
UINT64 *DmaInfoTable;

DmaInfoTable = val_aligned_alloc(SIZE_4K, sizeof(DMA_INFO_TABLE)
+ sizeof(DMA_INFO_BLOCK));
+ (2 * sizeof(DMA_INFO_BLOCK)));
val_dma_create_info_table(DmaInfoTable);
}

VOID
createPeripheralInfoTable(
)
Expand Down
10 changes: 8 additions & 2 deletions pal/uefi_acpi/src/pal_dma.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,19 @@ pal_dma_create_info_table(DMA_INFO_TABLE *dma_info_table)
return;
}

/* Expose a single coherent DMA-capable instance so the test can run. */
dma_info_table->num_dma_ctrls = 1;
/* Expose two DMA-capable instances so the test can exercise both coherent and non-coherent. */
dma_info_table->num_dma_ctrls = 2;
dma_info_table->info[0].host = NULL;
dma_info_table->info[0].port = gPalDmaPciIo;
dma_info_table->info[0].target = NULL;
dma_info_table->info[0].flags = DMA_COHERENT;
dma_info_table->info[0].type = DMA_TYPE_OTHER;

dma_info_table->info[1].host = NULL;
dma_info_table->info[1].port = gPalDmaPciIo;
dma_info_table->info[1].target = NULL;
dma_info_table->info[1].flags = DMA_NOT_COHERENT;
dma_info_table->info[1].type = DMA_TYPE_OTHER;
}

/**
Expand Down
10 changes: 8 additions & 2 deletions pal/uefi_dt/src/pal_dma.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,13 +114,19 @@ pal_dma_create_info_table(DMA_INFO_TABLE *dma_info_table)
return;
}

/* Expose a single coherent DMA-capable instance so the test can run. */
dma_info_table->num_dma_ctrls = 1;
/* Expose two DMA-capable instances so the test can exercise both coherent and non-coherent. */
dma_info_table->num_dma_ctrls = 2;
dma_info_table->info[0].host = NULL;
dma_info_table->info[0].port = gPalDmaPciIo;
dma_info_table->info[0].target = NULL;
dma_info_table->info[0].flags = DMA_COHERENT;
dma_info_table->info[0].type = DMA_TYPE_OTHER;

dma_info_table->info[1].host = NULL;
dma_info_table->info[1].port = gPalDmaPciIo;
dma_info_table->info[1].target = NULL;
dma_info_table->info[1].flags = 0;
dma_info_table->info[1].type = DMA_TYPE_OTHER;
}

/**
Expand Down
11 changes: 10 additions & 1 deletion test_pool/peripherals/d004.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ payload_check_dma_mem_attribute(void)
{
target_dev_index--; /* Index is zero based */
/* Allocate DMA memory based on coherency */
if (val_dma_get_info(DMA_HOST_COHERENT, target_dev_index))
if (val_dma_get_info(DMA_HOST_COHERENT, target_dev_index) & DMA_COHERENT)
{
dma_flags = DMA_COHERENT;
status = val_dma_mem_alloc(&buffer, 512, target_dev_index, DMA_COHERENT, &dma_addr);
Expand Down Expand Up @@ -165,15 +165,23 @@ payload_check_io_coherent_dma_mem_attribute(void)
if (status == ACS_STATUS_PAL_NOT_IMPLEMENTED) {
goto test_warn_unimplemented;
}
else if (status) {
val_print(WARN, "\n Error during DMA alloc. %x", status);
val_set_status(index, RESULT_FAIL(1));
flag_fail = 1;
continue;
}
ret = val_dma_mem_get_attrs(buffer, &attr, &sh);
if (ret == ACS_STATUS_PAL_NOT_IMPLEMENTED) {
val_dma_mem_free(buffer, dma_addr, 512, target_dev_index, DMA_COHERENT);
goto test_warn_unimplemented;
} else if (ret) {
val_print(ERROR,
"\n DMA controller %d: Failed to get memory attributes",
target_dev_index);
val_set_status(index, RESULT_FAIL(1));
flag_fail = 1;
val_dma_mem_free(buffer, dma_addr, 512, target_dev_index, DMA_COHERENT);
continue;
}
/* Check Inner Write-Back, Outer Write-Back, Inner Shareable */
Expand All @@ -187,6 +195,7 @@ payload_check_io_coherent_dma_mem_attribute(void)
val_set_status(index, RESULT_FAIL(2));
flag_fail = 1;
}
val_dma_mem_free(buffer, dma_addr, 512, target_dev_index, DMA_COHERENT);
}
}
/* PASS the test if no fail conditions hit */
Expand Down
3 changes: 2 additions & 1 deletion val/src/rule_metadata.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -847,7 +847,7 @@ rule_test_map_t rule_test_map[RULE_ID_SENTINEL] = {
.test_entry_id = D007_ENTRY,
.module_id = PERIPHERAL,
.rule_desc = "Check DMA for I/O coherency",
.platform_bitmask = PLATFORM_BAREMETAL | PLATFORM_LINUX,
.platform_bitmask = PLATFORM_BAREMETAL | PLATFORM_UEFI | PLATFORM_LINUX,
.flag = BASE_RULE,
.test_num = ACS_PER_TEST_NUM_BASE + 7,
},
Expand Down Expand Up @@ -3520,6 +3520,7 @@ test_entry_fn_t test_entry_func_table[TEST_ENTRY_SENTINEL] = {
[D006_ENTRY] = d006_entry,
[D008_ENTRY] = d008_entry,
[D004_ENTRY] = d004_entry,
[D007_ENTRY] = d007_entry,
[E001_ENTRY] = e001_entry, // used in wrapper.
[E002_ENTRY] = e002_entry, // used in wrapper.
[E003_ENTRY] = e003_entry,
Expand Down
Loading