test: add the version-16 python, javascript and e2e suite - #78
Merged
aakvatech merged 45 commits intoSep 4, 2026
Merged
Conversation
# Conflicts: # .gitignore # propms/__init__.py # propms/auto_custom.py # propms/hooks.py # propms/issue_hook.py # propms/lease_invoice.py # propms/lease_invoice_schedule.py # propms/pos.js # propms/property_management_solution/doctype/lease/lease.py # propms/property_management_solution/doctype/property/property.py # propms/property_management_solution/report/invoice_details/other_methods.py # propms/property_management_solution/report/mis_income_break_up/other_methods.py # propms/property_management_solution/report/rent_invoices_details/rent_invoices_details.py # propms/property_management_solution/report/rent_invoices_details_usd/rent_invoices_details_usd.py # propms/property_management_solution/report/subscription_service_report/subscription_service_report.js # propms/property_management_solution/report/utility_invoices/other_methods.py # pyproject.toml
aakvatech
merged commit Sep 4, 2026
4a146f1
into
Aakvatech-Limited:version-16-hotfix
3 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
propms had no runnable tests:
propms/tests/held only an__init__.pythat setfrappe.flags.skip_test_records, a flag Frappe 16 no longer reads, and the 27test_*.jsfiles underdoctype/were QUnit scaffolds for a runner Frapperemoved several versions ago. This PR replaces both with a suite that runs.
Python: 120 tests
The Frappe test runner, pointed at a dedicated
-test.localhostsite.test_hooksdoc_events,scheduler_events,after_install,after_migrateandbefore_teststarget resolves; everydoctype_js/page_jsasset exists and its DocType or Page existstest_v16_compatfrappe.db.commit()reachable from a document hook, no/approutes, no deprecated v15 test flags, the version string,get_alldefault ordering, expression filters, InnoDBtest_leasetest_propertytest_property_incrementtest_invoice_scheduletest_lease_invoicetest_issue_hooktest_auto_customtest_pos,test_installtest_reportstest_doctype_schema,test_doctype_controllerspropms/tests/utils.pyholds the bootstrap (before_tests, registered inhooks.py) and the factories. It completes setup for_Test Property Companyin TZS and builds properties, leases, items and customers on demand.
Statement coverage of the propms package is 62.1% (2016 statements, 1252
covered).
JavaScript: 271 tests
npm install && npm test, vitest on jsdom, no bench required. Client scriptsrun against a mocked desk global (
frappe.ui.form.on,frappe.call,frappe.require,erpnext.PointOfSale), wrapped in an IIFE the way version 16evaluates report and page scripts.
/approutes, theremoved offline POS API and interpolated
__()calls;renewal banner), the POS cost centre control, and the Company, Sales Invoice
and Property tree scripts.
Statement coverage of the shipped
.jsfiles is 61.6%.End to end: 12 tests
propms/tests/e2e/, skipped unlessPROPMS_E2E_BASE_URLis set.test_rest_api.pydrives the REST surface withrequests: resources,whitelisted methods, a query report over HTTP, and the version-16 rule that
logoutis POST-only.test_desk_ui.pydrives Chrome with Playwright over all 27 desk surfaces andfails on any console error.
Also here
the app's semgrep
cur_frmwarnings;package.json,package-lock.jsonandvitest.config.jsfor the JS harness,with
node_modules/andcoverage/ignored. No CI workflow is added: testsstay local, per the app's CI policy.
Depends on #77.