ENG-1924: Promote staging files without adding a release/ prefix#3851
Merged
Conversation
The S3 promoter stripped the staging/ prefix and then prepended release/, so every promoted object landed under release/... instead of at the bucket root. Beta update files went to release/update/state/beta/ rather than update/state/beta/, and release-channel files gained a doubled release/ segment. Since the updater only ever fetches from update/state/<channel>/, the prefix broke updates for every channel. Promotion now maps staging/<key> to <key>: the channel is already encoded in the path, so no prefix is added. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mitchell-as
changed the base branch from
version/0-48-1-RC3
to
version/0-48-1-RC4
July 21, 2026 14:29
Collaborator
Author
|
Tested this when promoting RC3 to production and it worked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENG-1924: Promote staging files without adding a release/ prefix
The promote-staging-to-production step was moving beta release files to release/update/state/beta/ instead of update/state/beta/, which forced a manual copy in the S3 console after every promotion. The promoter stripped the staging/ prefix and then prepended release/, so files landed one directory too deep. Because the updater only ever fetches from update/state//, this actually misplaced files for every channel, not just beta.
The fix drops the release/ prefix so promotion maps staging/ straight to ; the channel (beta, release, ...) is already part of the path. Beta files now land in update/state/beta/ and release-channel files in update/state/release/, matching what the updater serves.
Base branch: targets version/0-48-1-RC3.
🤖 Generated with Claude Code