Skip to content

Add config option to change server port - #17

Open
kmarius wants to merge 1 commit into
Adam-:http-pluginfrom
kmarius:http-plugin
Open

Add config option to change server port#17
kmarius wants to merge 1 commit into
Adam-:http-pluginfrom
kmarius:http-plugin

Conversation

@kmarius

@kmarius kmarius commented Sep 25, 2020

Copy link
Copy Markdown

I wasn't sure if startUp should throw an exception if it fails. I just throw the last exception if none of the ports work.

@Adam-

Adam- commented Sep 25, 2020

Copy link
Copy Markdown
Owner

Any reason this is a list of ports and not just one port?

@kmarius

kmarius commented Sep 25, 2020

Copy link
Copy Markdown
Author

I run several clients with the same config. This makes sure each of them gets a free port.

@Adam-

Adam- commented Sep 25, 2020

Copy link
Copy Markdown
Owner

Does that make sense? You wouldn't be able to tell which client got which port so why is that useful?

@kmarius

kmarius commented Sep 26, 2020

Copy link
Copy Markdown
Author

I want to share the overwhelming majority of settings between my accounts, hence I only use one config. This way I can actually just switch accounts in OSRS without starting a new RL instance or logging to a different account. Right now I can only distinguish the accounts via API by their stats; I think it would make sense to expose the account name through the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants