Skip to content

Make Google Maps package self-contained - #204

Merged
AdamEssenmacher merged 2 commits into
mainfrom
codex/maps-self-contained-package
Aug 29, 2026
Merged

Make Google Maps package self-contained#204
AdamEssenmacher merged 2 commits into
mainfrom
codex/maps-self-contained-package

Conversation

@AdamEssenmacher

Copy link
Copy Markdown
Owner

Summary

  • Convert Google Maps to a self-contained 9.2.0.9 package with the pinned 9.2.0 XCFramework and 190-file resource bundle.
  • Remove consumer-time Xamarin.Build.Download usage while preserving the existing binding API, TFMs, minimum OS, native metadata, and resource mappings.
  • Add package-structure and isolated offline-build validation to the path-filtered Google workflow.

Commits

  1. Make Google Maps package self-contained
  2. Add Maps self-contained package validation

Validation

  • Shell syntax, workflow YAML parsing, Cake syntax, git diff check, and private-path/secret scans.
  • Fresh hash-verified Cake pack from no existing Maps externals.
  • Package structure: both XCFramework slices/architectures, native metadata, all 190 mappings/resources, target imports, and no XBD.
  • Direct and transitive consumers: native symbol linkage, one root bundle, 190 byte-identical files, and no dynamic GoogleMaps.framework.
  • Isolated proxy-blocked --no-restore build with unchanged NuGet state and empty XBD directory.
  • All five Maps simulator runtime cases.
  • Smoke packs for Places, GoogleAppMeasurement, Firebase Analytics, and SignIn, plus Places and SignIn consumer-shape checks.
  • Package discovery tests for zero, symbol-only, and multiple candidates.

The general CI workflow and local baseline/generated artifacts are not included.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-29T21:54:58.987147Z e29e373 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AdamEssenmacher
AdamEssenmacher merged commit 9b26398 into main Aug 29, 2026
3 checks passed
@AdamEssenmacher
AdamEssenmacher deleted the codex/maps-self-contained-package branch August 29, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant