fix(mac): reduce GIF preview memory retention - #55
Open
ZephyrKeXiner wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 修改概述
fps) throughout the preview components, and making minor UI and logic improvements elsewhere.OLED GIF Preview Refactor and Optimization:
AnimatedGIFPreview(which loaded all frames into memory) with a newAnimatedGIFViewandAnimatedGIFPlayerthat only decodes and displays the current frame at the required size, greatly reducing memory usage when previewing large GIFs. [1] [2]fpsvalue, ensuring playback speed matches the asset’s intended frame rate. [1] [2] [3] [4]UI and Logic Improvements:
VibeBarBridge, ensured old subscriptions are removed before rebinding to prevent duplicate callbacks and memory leaks when views are recreated.Minor and Cleanup:
currentOLEDPreviewImageand related image-loading code. [1] [2]import ImageIOfor GIF decoding.These changes collectively improve performance, reduce memory usage, and make the OLED GIF preview more robust and responsive.