Support gradual rollout flag for realtime updates - #328
Open
Mishenevd wants to merge 1 commit into
Open
Conversation
Backend can now enable realtime config updates per-account via an enabledFeatures list on the config response, ahead of the agent having AIKIDO_FEATURE_SSE set locally. SSE starts if either is true.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
| boolean block, | ||
| List<String> excludedUserIdsFromRateLimiting | ||
| List<String> excludedUserIdsFromRateLimiting, | ||
| List<String> enabledFeatures |
Member
There was a problem hiding this comment.
It might be possible that this becomes null if not set in Core response? And then new HashSet<>(null) might throw? Not a Java export tho.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backend can now enable realtime updates per-account via an
enabledFeatureslist on the config response, ahead ofAIKIDO_FEATURE_SSEbeing set locally. SSE starts if either is true.Mirrors the change already merged in firewall-node and firewall-ruby. Feature name is
realtime_updates, matching the backend.APIResponsekeeps an 11-arg constructor defaultingenabledFeaturesto empty, so the ~25 existing call sites in tests are untouched.Testing:
ServiceConfiguration/ServiceConfigStore: defaults to false, true when present, false again once removed, false for an unrelated feature name