Merge nested-object-end-marker - #47
Closed
AlexanderBuzz wants to merge 2 commits into
Closed
Conversation
- Docker and the test instructions move out of "Examples", where they were subsections, into a "Development" block at the end - New section "The objects behind the client" for the classes added in 2.2.0, which the README did not mention although the Sugar functions are deprecated in their favour - The five examples that were missing from the list are added Fixes three defects in the code samples: - The account_objects sample called getBody() on the return of syncRequest(), which is a BaseResponse and has no such method, so it died with a fatal error. It also carried an "Account Info" heading over an AccountObjectsRequest. - The payment sample derived the operational wallet from the standby seed. - It sent 100 XRP, exactly what the faucet hands out, so following it with a faucet wallet yields tecUNFUNDED_PAYMENT because reserve and fee are left uncovered. The payment sample now leads with submitAndWait($tx, autofill: true, wallet: $wallet), which only started working with the getSignedTx() fix in 2.2.0, and keeps the sign-then-submit form as the alternative the files in examples/ use. All samples were run against the Testnet.
- Docker and the test instructions move out of "Examples", where they were subsections, into a "Development" block at the end - New section "The objects behind the client" for the classes added in 2.2.0, which the README did not mention although the Sugar functions are deprecated in their favour - The five examples that were missing from the list are added Fixes three defects in the code samples: - The account_objects sample called getBody() on the return of syncRequest(), which is a BaseResponse and has no such method, so it died with a fatal error. It also carried an "Account Info" heading over an AccountObjectsRequest. - The payment sample derived the operational wallet from the standby seed. - It sent 100 XRP, exactly what the faucet hands out, so following it with a faucet wallet yields tecUNFUNDED_PAYMENT because reserve and fee are left uncovered. The payment sample now leads with submitAndWait($tx, autofill: true, wallet: $wallet), which only started working with the getSignedTx() fix in 2.2.0, and keeps the sign-then-submit form as the alternative the files in examples/ use. All samples were run against the Testnet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TBD