Skip to content

OCTRL-1095: Create observability stack for kubernetes operators#822

Draft
justonedev1 wants to merge 3 commits into
masterfrom
OCTRL-1095-all
Draft

OCTRL-1095: Create observability stack for kubernetes operators#822
justonedev1 wants to merge 3 commits into
masterfrom
OCTRL-1095-all

Conversation

@justonedev1

Copy link
Copy Markdown
Collaborator

No description provided.

Comment on lines +94 to +95
ConditionStateInitialized = "StateInitialized"
ConditionStateTransitioned = "StateTransitioned"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do they mean exaclty? State transition started and finished?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConditionStateInitialized means that we were able to query the state of the OCC task
ConditionStateTransitioned just reports the Transitions between states

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, then maybe i'd propose to rename them to have less ambiguous meaning:

  • StateAccessible
  • LastStateTransitionResult

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(subject to discussion of course)

Comment thread control-operator/internal/controller/task_controller.go
Comment thread docs/k3s_observability.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants