Skip to content

[Common et all] Fix includes#16941

Open
vkucera wants to merge 11 commits into
AliceO2Group:masterfrom
vkucera:iwyu
Open

[Common et all] Fix includes#16941
vkucera wants to merge 11 commits into
AliceO2Group:masterfrom
vkucera:iwyu

Conversation

@vkucera

@vkucera vkucera commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot changed the title Iwyu [Common,DPG,ALICE3,PWGCF,PWGDQ,PWGEM,PWGHF,PWGJE,PWGLF,PWGUD] Iwyu Jul 6, 2026
@alibuild alibuild mentioned this pull request Jul 6, 2026
Closed
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 2856 errors, ⚠️ 4334 warnings, 🔕 31 disabled

@vkucera vkucera marked this pull request as ready for review July 6, 2026 20:12
amatyja
amatyja previously approved these changes Jul 6, 2026
View reviewed changes

@amatyja amatyja left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Wit, UD part is fine. Thank you.

prchakra
prchakra previously approved these changes Jul 6, 2026
View reviewed changes
@alibuild

alibuild commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 929bc9d at 2026-07-06 23:34:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 2037 errors and 2296 warnings.'
Found 2037 errors and 2296 warnings.
++ [[ 2037 -gt 0 ]]
++ cat /sw/BUILD/2ea96accfa5b69a771204e741726cbd9f6ef55fc/O2Physics-code-check/errors.txt
ALICE3/Core/OTFParticle.h:45:5: error: 'mPdgCode' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:46:5: error: 'mGlobalIndex' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:47:5: error: 'mCollisionId' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:48:5: error: 'mPx' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:49:5: error: 'mPy' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:50:5: error: 'mPz' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:51:5: error: 'mE' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:52:5: error: 'mVx' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:53:5: error: 'mVy' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:54:5: error: 'mVz' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:55:5: error: 'mVt' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:56:5: error: 'mFlag' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:57:5: error: 'mStatusCode' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:58:5: error: 'mIsFromMcParticles' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:105:3: error: function 'pdgCode' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:106:3: error: function 'globalIndex' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:107:3: error: function 'collisionId' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:108:3: error: function 'isAlive' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:109:3: error: function 'isPrimary' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:110:3: error: function 'isFromMcParticles' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:111:3: error: function 'weight' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:116:3: error: function 'flags' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:117:3: error: function 'statusCode' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:118:3: error: function 'vx' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:119:3: error: function 'vy' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:120:3: error: function 'vz' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:121:3: error: function 'vt' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:122:3: error: function 'px' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:123:3: error: function 'py' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:124:3: error: function 'pz' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:125:3: error: function 'e' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:126:3: error: function 'radius' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:127:3: error: function 'r' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:128:3: error: function 'pt' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:129:3: error: function 'p' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:130:3: error: function 'phi' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:131:3: error: function 'eta' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:138:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:142:3: error: function 'y' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:149:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:153:3: error: function 'getMotherIndexStart' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:154:3: error: function 'getMotherIndexStop' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 45c4350 at 2026-07-07 02:06:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 2037 errors and 2296 warnings.'
Found 2037 errors and 2296 warnings.
++ [[ 2037 -gt 0 ]]
++ cat /sw/BUILD/0a19c407fa335e734b66c29caa32a1c2d6ae5559/O2Physics-code-check/errors.txt
ALICE3/Core/OTFParticle.h:45:5: error: 'mPdgCode' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:46:5: error: 'mGlobalIndex' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:47:5: error: 'mCollisionId' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:48:5: error: 'mPx' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:49:5: error: 'mPy' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:50:5: error: 'mPz' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:51:5: error: 'mE' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:52:5: error: 'mVx' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:53:5: error: 'mVy' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:54:5: error: 'mVz' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:55:5: error: 'mVt' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:56:5: error: 'mFlag' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:57:5: error: 'mStatusCode' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:58:5: error: 'mIsFromMcParticles' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:105:3: error: function 'pdgCode' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:106:3: error: function 'globalIndex' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:107:3: error: function 'collisionId' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:108:3: error: function 'isAlive' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:109:3: error: function 'isPrimary' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:110:3: error: function 'isFromMcParticles' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:111:3: error: function 'weight' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:116:3: error: function 'flags' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:117:3: error: function 'statusCode' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:118:3: error: function 'vx' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:119:3: error: function 'vy' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:120:3: error: function 'vz' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:121:3: error: function 'vt' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:122:3: error: function 'px' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:123:3: error: function 'py' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:124:3: error: function 'pz' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:125:3: error: function 'e' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:126:3: error: function 'radius' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:127:3: error: function 'r' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:128:3: error: function 'pt' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:129:3: error: function 'p' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:130:3: error: function 'phi' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:131:3: error: function 'eta' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:138:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:142:3: error: function 'y' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:149:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:153:3: error: function 'getMotherIndexStart' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:154:3: error: function 'getMotherIndexStop' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amatyja amatyja amatyja left review comments
@prchakra prchakra prchakra left review comments
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@maoyx maoyx Awaiting requested review from maoyx maoyx is a code owner
@nzardosh nzardosh Awaiting requested review from nzardosh nzardosh is a code owner
@raymondEhlers raymondEhlers Awaiting requested review from raymondEhlers raymondEhlers is a code owner
@fjonasALICE fjonasALICE Awaiting requested review from fjonasALICE fjonasALICE is a code owner
@mhemmer-cern mhemmer-cern Awaiting requested review from mhemmer-cern mhemmer-cern is a code owner
@rolavick rolavick Awaiting requested review from rolavick rolavick is a code owner
@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner
@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner
@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner
@abmodak abmodak Awaiting requested review from abmodak abmodak is a code owner
@fmazzasc fmazzasc Awaiting requested review from fmazzasc fmazzasc is a code owner
@maciacco maciacco Awaiting requested review from maciacco maciacco is a code owner
@HorstMa HorstMa Awaiting requested review from HorstMa HorstMa is a code owner
@dmallick2 dmallick2 Awaiting requested review from dmallick2 dmallick2 is a code owner
@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner
@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner
@romainschotter romainschotter Awaiting requested review from romainschotter romainschotter is a code owner
@prottayCMT prottayCMT Awaiting requested review from prottayCMT prottayCMT is a code owner
@lhusova lhusova Awaiting requested review from lhusova lhusova is a code owner
@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner
@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner
@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner
@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner
@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner
@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner
@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner
@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner
@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner
@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner
@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner
@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner
@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner
@singhra1994 singhra1994 Awaiting requested review from singhra1994 singhra1994 is a code owner
@dsekihat dsekihat Awaiting requested review from dsekihat dsekihat is a code owner
@jokonig jokonig Awaiting requested review from jokonig jokonig is a code owner
@hscheid hscheid Awaiting requested review from hscheid hscheid is a code owner
@mikesas mikesas Awaiting requested review from mikesas mikesas is a code owner
@rbailhac rbailhac Awaiting requested review from rbailhac rbailhac is a code owner
@feisenhu feisenhu Awaiting requested review from feisenhu feisenhu is a code owner
@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner
@mcoquet642 mcoquet642 Awaiting requested review from mcoquet642 mcoquet642 is a code owner
@lucamicheletti93 lucamicheletti93 Awaiting requested review from lucamicheletti93 lucamicheletti93 is a code owner
@jaelpark jaelpark Awaiting requested review from jaelpark jaelpark is a code owner
@wenyaCern wenyaCern Awaiting requested review from wenyaCern wenyaCern is a code owner
@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner
@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner
@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner
@abilandz abilandz Awaiting requested review from abilandz abilandz is a code owner
@EmilGorm EmilGorm Awaiting requested review from EmilGorm EmilGorm is a code owner
@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner
@wrzesaCERN wrzesaCERN Awaiting requested review from wrzesaCERN wrzesaCERN is a code owner
@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern ariedel-cern is a code owner
@SwatiSaha-1997 SwatiSaha-1997 Awaiting requested review from SwatiSaha-1997 SwatiSaha-1997 is a code owner
@isputows isputows Awaiting requested review from isputows isputows is a code owner
@iouribelikov iouribelikov Awaiting requested review from iouribelikov iouribelikov is a code owner
@njacazio njacazio Awaiting requested review from njacazio njacazio is a code owner
@lbariogl lbariogl Awaiting requested review from lbariogl lbariogl is a code owner
@chiarazampolli chiarazampolli Awaiting requested review from chiarazampolli chiarazampolli is a code owner
@alcaliva alcaliva Awaiting requested review from alcaliva alcaliva is a code owner
@catalinristea catalinristea Awaiting requested review from catalinristea catalinristea is a code owner
@jesgum jesgum Awaiting requested review from jesgum jesgum is a code owner
@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner
@ktf ktf Awaiting requested review from ktf ktf is a code owner
@ddobrigk ddobrigk Awaiting requested review from ddobrigk ddobrigk is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

alice3 common datamodel dpg photon Photon and neutral meson PAG label pwgcf pwgdq pwgem pwghf PWG-HF pwgje pwglf pwgud

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vkucera @alibuild @amatyja @prchakra