fix(auth): prevent account enumeration on register and login (#83) - #90
Merged
Conversation
Registration now returns a single generic conflict message regardless of
which field collided, and login returns an identical 401 body with a
non-empty generic message for both unknown-user and bad-password cases
(previously the body serialized to {}). A dummy bcrypt compare equalizes
response timing when the user does not exist.
Owner
Author
|
closes #83 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unauthenticated auth endpoints disclosed whether an email/username belongs to an existing account:
409 "Username or email already exists"vs201revealed collisions (and which field, via message wording).{ error: result.error }whereresult.erroris undefined on a successful parse — both bodies serialized to{}, leaking no message at all, and bcrypt was skipped for unknown users, creating a timing side-channel.Changes
registerUser: single generic conflict body ({"error":"Registration failed"}) regardless of which field collided (409 kept, per issue direction).loginUser: identical401 {"error":"Invalid email or password"}for unknown-user and bad-password; also fixes the broken empty-body responses.Testing
TDD: both new tests watched failing first, then green.
closes #83.