[pull] main from mdn:main - #1248
Merged
Merged
Conversation
…ype (#44536) * ReadableStreamDefaultController.desiredSize: correct value type desiredSize is not always an integer: with a custom queuing strategy the chunk sizes (and therefore desiredSize) can be non-integer. It is also null when the stream has errored and 0 when it is closed. * Fix others --------- Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Bumps [cspell](https://github.com/streetsidesoftware/cspell/tree/HEAD/packages/cspell) from 10.2.1 to 10.2.2. - [Release notes](https://github.com/streetsidesoftware/cspell/releases) - [Changelog](https://github.com/streetsidesoftware/cspell/blob/main/packages/cspell/CHANGELOG.md) - [Commits](https://github.com/streetsidesoftware/cspell/commits/v10.2.2/packages/cspell) --- updated-dependencies: - dependency-name: cspell dependency-version: 10.2.2 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* More formally define expressions and operators * Grammar fix * Reviews * Apply batched suggestions from code review Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
* Fix connection logic that didn't catch failed connections * Also gate HTTP server start on successful MongoDB connection The bin/www generated by express-generator starts the HTTP server unconditionally, so simply fixing the connectMongoose() try/catch logic wasn't enough: readers following the tutorial would still end up with a server that starts regardless of whether the database connected. Move server creation into a startServer() function that only runs once connectMongoose() resolves, matching the upstream fix in mdn/express-locallibrary-tutorial#367. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018BoWRns9KXjAdyMZMeQ4g2 --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Fix small typos in prose
* adding webdriver cookie commands * addressing feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )