[pull] master from web-platform-tests:master - #2490
Merged
Merged
Conversation
Column grid-lanes fragmentation previously walked each lane independently. A spanner could therefore be visited before earlier items in all of its occupied lanes had been processed, or be treated as unstarted again after resuming from a child break token. Breaks inside a spanner also only blocked its start lane, allowing later content from another occupied lane into the current fragmentainer. Make the iterator defer column spanners until all preceding items across their span have been visited. Resumed spanners advance each occupied lane past its shared entry, and a fragmented spanner defers later content in its complete span. Row spanners will be handled in a follow up. There is a new crashing test, but this should be fixed once we support break rule handling in grid lanes. Bug: 343257585 Change-Id: I36ab0ecaa1eb8d2cb70062609cb2bd8f3112def3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8349061 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1692557}
Avoid counting border, scrollbar, and padding twice when computing intrinsic inline size for an empty row direction grid-lanes container. Bug: 343257585 Change-Id: I6086a4ffc8c26d6f2dae1da0c0a01ea9cd4f5968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8351020 Reviewed-by: Alison Maher <almaher@microsoft.com> Commit-Queue: Yanling Wang <yanlingwang@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1692564}
Co-authored-by: Andrew Martinez <amartinez55@apple.com>
Increase maxDifference to make tests match in Chrome. Numbers based on wpt.fyi results. Bug: 555826997, 557075192 Change-Id: Iada20c7b0303f6d3de3a94bd7285ae729c86c78e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8352705 Auto-Submit: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1692606}
When an invoker has both command and interest invoker attributes (e.g. commandfor and interestfor), opening the popover via the command invoker should not cause the popover to close when the button or popover subsequently loses interest. Previously, Element::InterestLost unconditionally hid the target popover on loss of interest, regardless of how it was opened. This CL introduces a PopoverInvokedVia enum to PopoverData to track how the popover was invoked (kNone, kInterest, or kCommand). Element::InterestLost now only hides popovers that were invoked via interest. If a popover opened via interest is subsequently invoked via a command (such as show-popover or menu activation), its invocation status upgrades to kCommand and its invoker is updated so that it persists when interest is lost. Fixed: 556283651 Bug: 406566432 Change-Id: Ibf92fa4c837b9a4640b66aca6febdd1d35fb04fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8344388 Reviewed-by: David Baron <dbaron@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1692665}
When encoding images from a linear float16 canvas (using toBlob, toDataURL, or convertToBlob), converting directly to 8-bit linear integers produces quantization artifacts at dark values (e.g. an sRGB-value gradient with 256 stops will only produce 183 unique output values). Add ImageEncoderUtils::GetColorInfoForEncoder to select an appropriate non-linear encoding color space (sRGB transfer function) when serializing linear float16 canvases, and ensure premultiplied alpha is converted to unpremultiplied alpha upfront. Include a gfx::HDRMetadata parameter which we can use, in the future, to select between sRGB and PQ. Apply this conversion in CanvasAsyncBlobCreator and ImageDataBuffer's StaticBitmapImage constructor. Log a warning in ImageDataBuffer(SkPixmap) if callers higher in the stack have not already performed any necessary conversion. Add WPT tests for toBlob, toDataURL, and convertToBlob with both JPEG and PNG formats across HTMLCanvasElement and OffscreenCanvas. TAG=agy CONV=6afb9a4e-b9e1-4c5a-9273-c80de68abad8 Bug: 454152417 Change-Id: Ifb6a25195e0cb39c80cabf00fab2ee39f6db8fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8342747 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1692722}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )