890 bug get itemsteal returns 500 internal server error if no request body is provided - #891
Merged
tickBit merged 2 commits intoAug 5, 2026
Conversation
… (StealTokenGuard)
constf03
requested review from
CapoMK25,
Iir0R,
MikhailDeriabin,
hoan301298,
psykkis and
tickBit
as code owners
August 5, 2026 08:48
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
tickBit
approved these changes
Aug 5, 2026
tickBit
left a comment
Collaborator
There was a problem hiding this comment.
Clean and good job! Approved.
tickBit
deleted the
890-bug-get-itemsteal-returns-500-internal-server-error-if-no-request-body-is-provided
branch
August 5, 2026 10:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description
This PR should fix a bug with endpoint GET /item/steal where it returns internal server error if no request body is provided instead of throwing unauthorized API Error like was intended to do.
Change list
updated
src/clanInventory/item/guards/StealToken.guard.tsrequest.body.steal_tokenorrequest.query.steal_tokenis not undefined before accessingstealToken(avoid TypeError that caused internal server error)updated
src/__tests__/clanInventory/item/guards/AuthGuard/canActivate.test.ts