Skip to content

convert time values to milliseconds in box/session service - #893

Merged
tickBit merged 1 commit into
devfrom
889-bug-numerical-times-in-sessionstarterservicets-not-in-milliseconds
Aug 5, 2026
Merged

convert time values to milliseconds in box/session service#893
tickBit merged 1 commit into
devfrom
889-bug-numerical-times-in-sessionstarterservicets-not-in-milliseconds

Conversation

@constf03

@constf03 constf03 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Brief description

This PR converts the numerical times in SessionStarterService into milliseconds.
Because const now = new Date().getTime(); returns current date in milliseconds the other time variables must be in milliseconds too.

Change list

  • updated src/box/sessionStarter/sessionStarter.service.ts and src/__tests__/box/SessionStarterService/start.test.ts
    • multiply const timeAfterWeek and const timeAfterMonth by 1000 to convert them into milliseconds:
      const now = new Date().getTime();
      const timeAfterWeek = now + 60 * 60 * 24 * 7 * 1000;
      const timeAfterMonth = now + 60 * 60 * 24 * 30 * 1000;
    

@codecov-alt

codecov-alt Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/box/sessionStarter/sessionStarter.service.ts 93.20% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tickBit tickBit left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Approved.

@github-project-automation github-project-automation Bot moved this from Backlog to Done in Altzone-Server Aug 5, 2026
@tickBit
tickBit merged commit 4ba9b1d into dev Aug 5, 2026
5 checks passed
@tickBit
tickBit deleted the 889-bug-numerical-times-in-sessionstarterservicets-not-in-milliseconds branch August 5, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Bug: Numerical times in sessionStarter.service.ts not in milliseconds

2 participants