894 bug battlestart returns 500 when custom matchid is not a mongo objectid - #898
Merged
CapoMK25 merged 4 commits intoAug 7, 2026
Conversation
tickBit
requested review from
CapoMK25,
Iir0R,
MikhailDeriabin,
hoan301298 and
psykkis
as code owners
August 7, 2026 08:37
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
CapoMK25
approved these changes
Aug 7, 2026
CapoMK25
left a comment
Collaborator
There was a problem hiding this comment.
Solid, approved. Be wary in the future with ObjectID vs string mismatches just in case, this PR/issue combo won't likely introduce them, but they're a common pain point in unit testing on bigger issues regardless.
CapoMK25
deleted the
894-bug-battlestart-returns-500-when-custom-matchid-is-not-a-mongo-objectid
branch
August 7, 2026 14:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description
There used to be allowed in the
startBattle.dto.ts@IsStringcustom matchId, but using custom string caused 500 internal server error. To accept custom string without 500 internal server error requires changes to database schema.Now
matchIdfield must be MongoDB style string. It can be custom string with if it's also a 24 byte MongoDB string at the same time.I
git stashed the prettier/linting changes of other files.Issue #894
Change list