Skip to content

Do not report host deletion as completed on an unknown API error #2057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
somanchi004-code wants to merge 1 commit into
base: 0.27.4
Choose a base branch
from
+18 −4
Open

Do not report host deletion as completed on an unknown API error #2057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions pkg/controller/chi/worker-deleter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"time"

core "k8s.io/api/core/v1"
apiErrors "k8s.io/apimachinery/pkg/api/errors"
meta "k8s.io/apimachinery/pkg/apis/meta/v1"

log "github.com/altinity/clickhouse-operator/pkg/announcer"
Expand Down Expand Up @@ -539,12 +540,25 @@ func (w *worker) deleteHost(ctx context.Context, chi *api.ClickHouseInstallation

var err error
if host.Runtime.CurStatefulSet, err = w.c.kube.STS().Get(ctx, host); err != nil {
w.a.WithEvent(host.GetCR(), a.EventActionDelete, a.EventReasonDeleteCompleted).
WithAction(host.GetCR()).
if apiErrors.IsNotFound(err) {
// StatefulSet is gone for sure - the host is already deleted.
w.a.WithEvent(host.GetCR(), a.EventActionDelete, a.EventReasonDeleteCompleted).
WithAction(host.GetCR()).
M(host).F().
Info("Delete host: %s/%s - completed StatefulSet not found - already deleted",
host.Runtime.Address.ClusterName, host.GetName())
return nil
}
// Unable to tell whether the StatefulSet exists.
// Do not report deletion as completed - the cleanup below is skipped, and the host's
// PVCs carry no owner reference (see model/common/creator/pvc.go), so nothing else
// would reclaim them. Report the failure and let the caller decide.
w.a.WithEvent(host.GetCR(), a.EventActionDelete, a.EventReasonDeleteFailed).
WithError(host.GetCR()).
M(host).F().
Info("Delete host: %s/%s - completed StatefulSet not found - already deleted? err: %v",
Error("Delete host: %s/%s - unable to get StatefulSet, host deletion not performed. err: %v",
host.Runtime.Address.ClusterName, host.GetName(), err)
return nil
return err
}

// Pre-delete host hooks: run BEFORE we touch the host's k8s objects so the pod is
Expand Down
Loading