fix(ci): map stylekit-core/styles in tsconfig so typecheck and build … - #24
fix(ci): map stylekit-core/styles in tsconfig so typecheck and build …#24hasong66 wants to merge 1 commit into
Conversation
…resolve it packages/mcp/src/data.ts imports from "stylekit-core/styles", but the root tsconfig paths only mapped "stylekit-core" and "stylekit-core/discovery". CI runs `tsc --noEmit` and `next build` without pre-building the core package, so the unmapped subpath could not be resolved from source and both jobs failed with TS2307 "Cannot find module 'stylekit-core/styles'". Add the missing path entry, mirroring the existing discovery mapping. Verified: `tsc --noEmit` passes even with packages/core/dist removed, proving resolution now comes from source as CI needs.
|
Someone is attempting to deploy a commit to the Anx's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 2 reviews per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe TypeScript configuration adds the ChangesStyles alias
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized TypeScript path-mapping change enables CI to resolve stylekit-core/styles from source; no actionable merge-blocking risk remains based on the supplied evidence. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…resolve it
packages/mcp/src/data.ts imports from "stylekit-core/styles", but the root tsconfig paths only mapped "stylekit-core" and "stylekit-core/discovery". CI runs
tsc --noEmitandnext buildwithout pre-building the core package, so the unmapped subpath could not be resolved from source and both jobs failed with TS2307 "Cannot find module 'stylekit-core/styles'". Add the missing path entry, mirroring the existing discovery mapping. Verified:tsc --noEmitpasses even with packages/core/dist removed, proving resolution now comes from source as CI needs.Summary
What changed:
Why:
Change Type
feat— new feature or stylefix— bug fixrefactor— code improvement (no behavior change)docs— documentation onlychore— build, CI, or toolingScope
Style Contribution Checklist
___docs/STYLE_ADDITION_CHECKLIST.mdcompletely/styles/<slug>loads correctly/styles/<slug>/showcaserenders all 12+ sectionsValidation
pnpm run security:secrets— no secrets detectedpnpm run lint— no errorsnpx tsc --noEmit— no type errorspnpm test— all tests passpnpm build— builds successfullySecurity
.envfiles committedNEXT_PUBLIC_Breaking Changes
Screenshots
Notes for Reviewers
Summary by CodeRabbit