Skip to content

fix(ci): map stylekit-core/styles in tsconfig so typecheck and build … - #24

Closed
hasong66 wants to merge 1 commit into
AnxForever:mainfrom
hasong66:fix/ci-tsconfig-stylekit-core-styles
Closed

fix(ci): map stylekit-core/styles in tsconfig so typecheck and build …#24
hasong66 wants to merge 1 commit into
AnxForever:mainfrom
hasong66:fix/ci-tsconfig-stylekit-core-styles

Conversation

@hasong66

@hasong66 hasong66 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

…resolve it

packages/mcp/src/data.ts imports from "stylekit-core/styles", but the root tsconfig paths only mapped "stylekit-core" and "stylekit-core/discovery". CI runs tsc --noEmit and next build without pre-building the core package, so the unmapped subpath could not be resolved from source and both jobs failed with TS2307 "Cannot find module 'stylekit-core/styles'". Add the missing path entry, mirroring the existing discovery mapping. Verified: tsc --noEmit passes even with packages/core/dist removed, proving resolution now comes from source as CI needs.

Summary

What changed:

Why:

Change Type

  • feat — new feature or style
  • fix — bug fix
  • refactor — code improvement (no behavior change)
  • docs — documentation only
  • chore — build, CI, or tooling

Scope

  • Styles / Recipes / Tokens
  • UI Components
  • API Endpoints
  • Templates / Animations
  • Build / CI
  • Documentation

Style Contribution Checklist

Skip this section if your PR doesn't add a new style.

  • Style slug: ___
  • Followed docs/STYLE_ADDITION_CHECKLIST.md completely
  • Created all 6 required files (definition, tokens, recipes, showcase page + content, cover SVG)
  • Updated all 4 registration files (index, meta, recipes/index, style-components)
  • Verified /styles/<slug> loads correctly
  • Verified /styles/<slug>/showcase renders all 12+ sections
  • Attached screenshots below

Validation

  • pnpm run security:secrets — no secrets detected
  • pnpm run lint — no errors
  • npx tsc --noEmit — no type errors
  • pnpm test — all tests pass
  • pnpm build — builds successfully

Security

  • No secrets, credentials, or .env files committed
  • Server-side values are not exposed via NEXT_PUBLIC_

Breaking Changes

  • None
  • Yes (describe below)

Screenshots

Notes for Reviewers

Summary by CodeRabbit

  • Chores
    • Added support for resolving the core styles module through the project’s configured import paths.

…resolve it

packages/mcp/src/data.ts imports from "stylekit-core/styles", but the root
tsconfig paths only mapped "stylekit-core" and "stylekit-core/discovery". CI
runs `tsc --noEmit` and `next build` without pre-building the core package,
so the unmapped subpath could not be resolved from source and both jobs failed
with TS2307 "Cannot find module 'stylekit-core/styles'". Add the missing path
entry, mirroring the existing discovery mapping. Verified: `tsc --noEmit`
passes even with packages/core/dist removed, proving resolution now comes from
source as CI needs.
@vercel

vercel Bot commented Aug 18, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the Anx's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7fa91969-5162-43a8-872f-990556e00dc9

📥 Commits

Reviewing files that changed from the base of the PR and between 29141b6 and 592b3e2.

📒 Files selected for processing (1)
  • tsconfig.json

Included review availability: Your plan includes up to 2 reviews per rolling hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The TypeScript configuration adds the stylekit-core/styles path alias and retains the existing stylekit-core/discovery alias.

Changes

Styles alias

Layer / File(s) Summary
Configure styles path alias
tsconfig.json
Adds stylekit-core/styles mapped to ./packages/core/src/styles/index.ts while retaining stylekit-core/discovery.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 592b3

This localized TypeScript path-mapping change enables CI to resolve stylekit-core/styles from source; no actionable merge-blocking risk remains based on the supplied evidence.

Suggested reviewers: anxforever

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the CI fix and the added stylekit-core/styles TypeScript mapping.
Description check ✅ Passed The description explains the cause, change, impact, and verification, although the template checkboxes and summary fields remain unfilled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hasong66 hasong66 closed this Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant