build: enforce ordinary managed diagnostic gates - #56
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ordinary managed builds now enforce the existing file-scoped namespace rule and fail analyzer warnings. Analyzer breadth, packages and runtime behavior are unchanged. Implements Design WP02.01 under merged Design PR47.
Validation: locked restore, full managed build and format, evaluated properties, real CS1030/IDE0161 rejection with restored successful builds, 63 engineering tests, provenance/licence checks, pre-commit, Windows native build (0 warnings/errors) and ABI test using the existing vcpkg tree. Packaging guard tests passed against the retained published baseline. Fresh immutable native/package consumers remain required PR CI gates; main publication and public verification remain pending.
Reviewed complete two-file diff. Retain branch/worktree; merge only after all applicable CI passes. No consumer package pin changes.