fix(cli): honor saved coordinator host - #898
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5daa4a2. Configure here.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
|
This pull request has been automatically marked as stale because it has had no activity for 14 days. It will be closed in 14 days if no further activity occurs. If this is still relevant, please leave a comment or remove the stale label. |
|
Addressed the missing-config review finding in commit 3aab68d and merged current upstream main. |
Greptile SummaryOrganization and project commands now resolve their coordinator URL from saved login configuration when no connection flags are supplied, while retaining explicit-option and production fallbacks.
Confidence Score: 4/5The PR appears safe to merge after addressing the non-blocking configuration-error handling and required package version update. The intended saved-host precedence is implemented consistently, but invalid existing configuration can now escape from callbacks as a traceback, and the repository-required library version increment is absent. Files Needing Attention: libs/arcade-cli/arcade_cli/utils.py and pyproject.toml
|
| Filename | Overview |
|---|---|
| libs/arcade-cli/arcade_cli/utils.py | Adds centralized saved-URL resolution, but non-missing configuration errors can escape from command callbacks. |
| libs/arcade-cli/arcade_cli/org.py | Changes the organization callback to distinguish an omitted host and delegate coordinator resolution. |
| libs/arcade-cli/arcade_cli/project.py | Applies the same coordinator-resolution behavior to project commands. |
| libs/tests/cli/test_org_project.py | Covers saved coordinator URLs, explicit host precedence, and production fallback, but not invalid configuration files. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Organization or project callback] --> B{Any connection flag supplied?}
B -- Yes --> C[Build URL from explicit options and production host fallback]
B -- No --> D[Load saved configuration]
D --> E{Saved coordinator URL exists?}
E -- Yes --> F[Use saved coordinator URL]
E -- No or file missing --> G[Use production coordinator URL]
Reviews (1): Last reviewed commit: "Merge branch 'main' into agent/use-saved..." | Re-trigger Greptile
|
This pull request has been automatically marked as stale because it has had no activity for 14 days. It will be closed in 14 days if no further activity occurs. If this is still relevant, please leave a comment or remove the stale label. |
…rdinator-host Signed-off-by: Aditya Datta <crazyme07071996@gmail.com>
Signed-off-by: Aditya Datta <crazyme07071996@gmail.com>
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.

Summary
Organization and project commands now use the coordinator URL saved by
arcade loginwhen no connection flags are provided, matching the behavior of the rest of the CLI. Explicit host, port, and TLS flags continue to take precedence.Resolves: #896
Design decisions
The fallback is centralized in
resolve_coordinator_urlso both command groups share the same precedence rules. The visible--hostdefault remains the production coordinator for help output, whileNoneinternally distinguishes an omitted flag from an explicit override.Test plan
uv run pytest libs/tests/cli/test_org_project.py(3 passed)uv run ruff checkfor the changed Python filesuv run ruff format --checkfor the changed Python filesAuthor checklist
Before moving this PR from Draft to Ready for Review:
make checkandmake testare green locally; CI is expected to passNote
Low Risk
CLI-only coordinator URL resolution for org/project commands; explicit flags and production fallback unchanged in spirit, with new unit test coverage.
Overview
arcade organdarcade projectno longer always target the production coordinator when connection flags are omitted. They now resolve the coordinator through newresolve_coordinator_url, which uses the URL saved atarcade loginwhen--hostis not passed, matching the rest of the CLI.--hostdefaults toNoneinternally (help still shows production viashow_default), so an omitted flag can fall back to config. Explicit--host,--port, and--tls/--no-tlsstill win; partial overrides reuse the saved host/scheme where appropriate. Missing or invalid config falls back tohttps://{PROD_COORDINATOR_HOST}.Adds
libs/tests/cli/test_org_project.pyfor these precedence rules and bumpsarcade-mcpto 1.15.3.Reviewed by Cursor Bugbot for commit b584205. Bugbot is set up for automated code reviews on this repo. Configure here.