Phase1/design fixes

[Rodern]

Design system small fixes — POS shim, CTA tokens, aria labels

Short summary

• Small, review-first Phase 1 changes that reduce runtime risk, improve accessibility, and begin token standardization across critical pages.
• Intentionally minimal and low-risk so reviewers can quickly validate and merge.

What this PR does

• Fixes a POS runtime error by making the amountTenderedInput shim tolerant of an existing global variable (prevents “Identifier 'amountTenderedInput' has already been declared”).
• Standardizes a set of high-value primary CTAs to the design token class button-primary on critical pages (POS, VerifyContact, BranchAdmin, BranchDashboard, CommunicationLogs).
• Adds aria-label attributes to important icon-only close buttons (POS receipt, Stock Transfers create blade, Suppliers drawer/modals) to improve screen-reader accessibility.
• Recreates the design audit used to guide these fixes: docs/design_consistency_report.md (full per-page checklist and recommended next steps).

Files changed (high level)

• Modified:
  • Store.UI/Pages/Pos.cshtml
  • Store.UI/Pages/VerifyContact.cshtml
  • Store.UI/Pages/BranchDashboard.cshtml
  • Store.UI/Pages/BranchAdmin.cshtml
  • Store.UI/Pages/CommunicationLogs.cshtml
  • Store.UI/Pages/StockTransfers.cshtml
  • Store.UI/Pages/Suppliers.cshtml
• Added:
  • docs/design_consistency_report.md

Why these changes

• POS shim: previously a duplicate const declaration caused script execution to fail for some deployments. The shim now checks window.amountTenderedInput first, preventing duplicate identifier errors while preserving legacy compatibility.
• CTA standardization: moving key CTAs to the semantic token class reduces visual inconsistency and prepares for the larger token migration (Phase 2).
• Aria labels: improves accessibility on icon-only controls and blades/drawers so screen readers expose meaningful actions.
• The report provides reviewers and implementers a single source of truth to plan follow-up phases.

Manual test instructions (quick)

1. Checkout branch: git fetch && git checkout phase1/design-fixes
2. Run the site and verify:
   • POS: open browser console and navigate to /Pos; ensure no runtime error about amountTenderedInput appears.
   • POS: barcode Add and Complete Checkout buttons render and function; verify no styling regressions.
   • Receipt blade: open and close with keyboard; verify the close button has an aria label (inspect element).
   • Suppliers drawer and StockTransfers create blade: open and confirm close buttons have aria-labels and keyboard operability.
   • BranchAdmin / BranchDashboard / CommunicationLogs: click the primary CTAs and confirm expected behavior and appearance.
3. Smoke-test other flows on same pages to confirm no regressions.

Review checklist (for reviewers)

• POS no longer throws duplicate identifier error in console.
• Primary CTAs on the updated pages render acceptably (visual check; no obvious breaks).
• Icon-only close buttons include an aria-label and are keyboard-accessible.
• docs/design_consistency_report.md is present and readable; contains the per-page checklist.
• No unrelated code or behaviour changes included.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
store-project	Error		Aug 24, 2026 1:28pm