Skip to content

Use git clone directly instead of gh (github command line) - #67

Open
sebastianhahta-hus wants to merge 2 commits into
Aridhia-Open-Source:mainfrom
sebastianhahta-hus:patch-1
Open

Use git clone directly instead of gh (github command line)#67
sebastianhahta-hus wants to merge 2 commits into
Aridhia-Open-Source:mainfrom
sebastianhahta-hus:patch-1

Conversation

@sebastianhahta-hus

Copy link
Copy Markdown

This patch removes use of gh to set up the repo and replaces it with git clone. git clone simplifies application firewall configuration, as it avoids the use of GitHub's GraphQL API endpoint required by gh clone. Since GitHub's GraphQL API uses a single endpoint (api.github.com/graphql) for all operations, it is difficult to define granular firewall rules.

@CodePint

CodePint commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

I suspect im using the graphql api in the federate node repo with dagster, why does its usage make firewall config difficult?

@sebastianhahta-hus

Copy link
Copy Markdown
Author

In the REST API, there are numerous endpoints which can be separately allowed in the firewall, eg. when the endpoint is in the form of https://api.github.com/repos/<org>/<repo>/..., it easy to set a rule allowing just one GitHub organization. With GraphQL all the API calls use the same endpoint https://api.github.com/graphql so the rules cannot be configured in the same way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants