Refactor TERCurve.apply_to() - #1004
Merged
Merged
Conversation
For detailed explanation see #1002, this is basically the same but for `TERCurve`. The new `.__call__()` in this case is exclusively for cubes, because 1D spectra work differently. But those could be simplified as well, and as a result the `combine_two_spectra` function was no longer needed. Also finally remove the long-deprecated `.fov_grid()` methods that were still here. Everything passes without them. Well, except of course `test_current_filter_has_fov_grid_method`...
teutoburg
added
refactor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1004 +/- ##
==========================================
+ Coverage 76.29% 76.44% +0.14%
==========================================
Files 69 69
Lines 9053 9029 -24
==========================================
- Hits 6907 6902 -5
+ Misses 2146 2127 -19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
astronomyk
approved these changes
Sep 4, 2026
github-project-automation
Bot
moved this from 👀 Awaiting Review
to ✅ Done
in ScopeSim-development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For detailed explanation see #1002, this is basically the same but for
TERCurve. The new.__call__()in this case is exclusively for cubes, because 1D spectra work differently. But those could be simplified as well, and as a result thecombine_two_spectrafunction was no longer needed.Also finally remove the long-deprecated
.fov_grid()methods that were still here. Everything passes without them. Well, except of coursetest_current_filter_has_fov_grid_method...