Skip to content

Rectify now accepts str and HDUList + stop mangling METISLMSSPectralTrace params dict - #985

Open
astronomyk wants to merge 3 commits into
mainfrom
fix/spectral-trace-robustness
Open

Rectify now accepts str and HDUList + stop mangling METISLMSSPectralTrace params dict#985
astronomyk wants to merge 3 commits into
mainfrom
fix/spectral-trace-robustness

Stop MetisLMSSpectralTrace writing into the caller's params dict

ae14246
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 24, 2026 in 1s

77.09% (+0.62%) compared to beb191d

View this Pull Request on Codecov

77.09% (+0.62%) compared to beb191d

Details

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.09%. Comparing base (beb191d) to head (ae14246).

Files with missing lines Patch % Lines
scopesim/effects/metis_lms_trace_list.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #985      +/-   ##
==========================================
+ Coverage   76.46%   77.09%   +0.62%     
==========================================
  Files          69       69              
  Lines        9025     9027       +2     
==========================================
+ Hits         6901     6959      +58     
+ Misses       2124     2068      -56     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.