Fix CI: remove broken Clang_jll import in generate_C_API.jl - #12
Merged
Conversation
Clang.jl (currently resolved v0.19.3) no longer exposes Clang_jll under
Clang.LibClang — that submodule now depends on Clang_unified_jll instead.
The unused `using Clang.LibClang.Clang_jll` import therefore fails with:
UndefVarError: `Clang_jll` not defined in `Clang.LibClang`
This broke deps/build.jl (which calls generate_C_API.jl) and made
"Test CalcPi.jl" and "Integration Test" fail in CI on every PR. The
import isn't referenced anywhere else in the file, so it's safe to drop.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YU8yMLZkRkqta9wbWPGfgx
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI was failing on every PR (Integration Test on ubuntu/macos, Test CalcPi.jl on ubuntu) with:
Root cause
CalcPi.jl/utils/generate_C_API.jlhas:The currently resolved
Clang.jl(v0.19.3) no longer depends onClang_jllfromClang.LibClang— that submodule now depends onClang_unified_jllinstead. TheClang_jllimport is not referenced anywhere else in the file, so it's dead code left over from an older Clang.jl API, and simply removing it fixes the build.Verification
Reproduced and fixed locally by running every step from
.github/workflows/ci.yml'stest-calcpi-jl/test-integrationjobs directly (deps/build.jl, thenPkg.test("CalcPi")), all of which now pass:Once merged, main's CI should go green again and the currently-blocked Dependabot PRs (#8, #9, #10, #11) should pass after a rebase/merge from main.
🤖 Generated with Claude Code
https://claude.ai/code/session_01YU8yMLZkRkqta9wbWPGfgx