Don't disconnect on abort - #10
Open
ARitz-Cracker wants to merge 1 commit into
Open
Conversation
Removed socket end handling on abort and added socket close and end event handlers to nullify `ctx.socket.` This is because postfix attempts to re-use the current connection on `abort` and considers a disconnection on the milter's side as an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8
I... have been using this change for years and I can't believe I haven't submitted a PR back then.
Postfix attempts to re-use the current connection on
abortand considers a disconnection on the milter's side as an error, this is especially noticeable when postfix has multiple messages are queued and is using multiple milters (like for DKIM and DMARC)Also nullified the socket in other places for consistency.