Please ignore: External contribution build of "Fix status bar icon contrast in bookmark dialogs"

[geekygecko]

Description

This PR is just to get the CI steps to run for the external contribution #5617

Fixes #

Testing Instructions

Screenshots or Screencast

Checklist

• If this is a user-facing change, I have added an entry in CHANGELOG.md
• Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
• I have considered whether it makes sense to add tests for my changes
• All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
• Any jetpack compose components I added or changed are covered by compose previews
• I have updated (or requested that someone edit) the Event Horizon schema to reflect any new or changed analytics.

I have tested any UI changes...

• with different themes
• with a landscape orientation
• with the device set to have a large display and font size
• for accessibility with TalkBack

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[claude]

Claude finished @geekygecko's task in 57s —— View job

---

PR Review: Fix status bar icon contrast in bookmark dialogs

• Gather context (diff, StatusBarIconColor, theme handling)
• Review the change
• Post feedback

---

This is a small, well-targeted fix. The change swaps the fallback status-bar icon color from StatusBarIconColor.Light to StatusBarIconColor.ThemeNoToolbar in BookmarksContainerFragment.

Why the change is correct

StatusBarIconColor.Light unconditionally forces light (white) status-bar icons. For a bottom-sheet dialog the status bar sits over the app background, so on a light theme that produced white-on-light icons — the contrast bug being fixed. ThemeNoToolbar instead defers to the theme's background luminance:

StatusBarIconColor.ThemeNoToolbar -> {
    if (activeTheme.backgroundLightIcons) {
        useLightStatusBarIcons(window)
    } else {
        useDarkStatusBarIcons(window)
    }
}

(modules/services/ui/.../theme/Theme.kt:422)

Because the dialog has no toolbar of its own, ThemeNoToolbar (background-based) is the semantically right variant — as opposed to Theme, which keys off toolbarLightIcons. This is also consistent with how WhatsNewFragment — another BaseDialogFragment — sets statusBarIconColor (modules/features/settings/.../whatsnew/WhatsNewFragment.kt:35).

Notes / things to confirm

• The PROFILE branch keeps StatusBarIconColor.Theme. That's presumably intentional (the profile entry point renders behind a toolbar), and the change leaves it untouched — good.
• Worth verifying visually across light and dark themes and each entry point (player vs. profile), since that's exactly the surface this affects. A quick TalkBack/contrast sanity check isn't needed, but a light-theme screenshot in the PR would make review airtight.

Verdict: ✅ Correct, minimal, and consistent with existing conventions. No code changes requested. CHANGELOG entry is present and properly formatted.

[claude]

Claude finished @geekygecko's task in 1m 0s —— View job

---

PR Review: Fix status bar icon contrast in bookmark dialogs

• Gather context (diff, BookmarksContainerFragment, Theme.kt, CHANGELOG)
• Review the code change
• Post feedback

---

Re-reviewed after reopen. This remains a small, correct, well-targeted fix.

The code change ✅

BookmarksContainerFragment.kt:54 swaps the non-profile fallback from StatusBarIconColor.Light to StatusBarIconColor.ThemeNoToolbar.

• Light unconditionally forces white status-bar icons, so on a light theme the bookmark bottom-sheet produced white-on-light icons — the contrast bug.
• ThemeNoToolbar defers to activeTheme.backgroundLightIcons (Theme.kt:422-428), which is the right signal for a dialog that has no toolbar of its own — the status bar sits over the app background, not a toolbar.
• Keeping the PROFILE branch on StatusBarIconColor.Theme (toolbar-based) is correct since that entry point renders behind a toolbar. Leaving it untouched is the right call.
• Consistent with how other BaseDialogFragments (e.g. WhatsNewFragment) set statusBarIconColor.

No code changes requested here.

One thing to fix: CHANGELOG placement 📝

The branch has no merge base with origin/main (git diff origin/main...HEAD errors with no merge base), so it diverged from an older point in history. As a result the CHANGELOG entry was added under the 8.17 section (CHANGELOG.md:13), but main has since opened an 8.18 section for unreleased work.

8.17
-----
...
*   Bug Fixes
    *   Fix status bar icon contrast in light-themed bookmark dialogs   ← currently here
        ([#2127](https://github.com/Automattic/pocket-casts-android/issues/2127))

8.17 already contains shipped/queued work, so this entry belongs under 8.18 instead. This will also surface as a merge conflict on the CHANGELOG when the PR is brought up to date. Recommend rebasing on latest main and moving the entry under the 8.18 → Bug Fixes heading.

Fix this →

Testing note

Worth a quick visual check across light and dark themes and both entry points (player vs. profile), since that's exactly the surface this affects. A light-theme screenshot in the PR description would make review airtight.

Verdict: Code change is correct, minimal, and consistent with conventions. Only follow-up is the CHANGELOG section (8.17 → 8.18) plus a rebase to clear the divergence.