Skip to content

Add max-height setting for code blocks #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
faisalahammad wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add max-height setting for code blocks #310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions syntaxhighlighter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ function_exists( 'parse_blocks' ) // WordPress 5.0+
'collapse' => 0,
'firstline' => 1,
'gutter' => 1,
'maxheight' => 0, // 0 disables the max-height cap
'htmlscript' => 0,
'light' => 0,
'padlinenumbers' => 'false',
Expand Down Expand Up @@ -1138,6 +1139,14 @@ function maybe_output_scripts() {
echo " SyntaxHighlighter.defaults['quick-code'] = false;\n";
}

if ( ! empty( $this->settings['maxheight'] ) ) {
$maxheight = (int) $this->settings['maxheight'];
echo " var maxheightcss = document.createElement( 'style' );\n";
echo " maxheightcss.setAttribute( 'type', 'text/css' );\n";
echo " maxheightcss.appendChild( document.createTextNode( '" . esc_attr( ".syntaxhighlighter { max-height: {$maxheight}px !important; overflow-y: auto !important; }" ) . "' ) );\n";
echo " document.head.appendChild( maxheightcss );\n";
}

?> SyntaxHighlighter.all();

// Infinite scroll support
Expand Down Expand Up @@ -1490,6 +1499,14 @@ function settings_page() { ?>
</fieldset>
</td>
</tr>
<tr valign="top">
<th scope="row"><label for="syntaxhighlighter-maxheight"><?php esc_html_e( 'Max Height (in pixels)', 'syntaxhighlighter' ); ?></label></th>
<td>
<input name="syntaxhighlighter_settings[maxheight]" type="text" id="syntaxhighlighter-maxheight" value="<?php echo esc_attr( $this->settings['maxheight'] ); ?>" class="small-text" />
<br />
<?php esc_html_e( 'The maximum height of a code block before a vertical scrollbar appears. Set to 0 to disable.', 'syntaxhighlighter' ); ?>
</td>
</tr>
</table>

<h3><?php esc_html_e( 'Defaults', 'syntaxhighlighter' ); ?></h3>
Expand Down Expand Up @@ -1811,6 +1828,7 @@ function validate_settings( $settings ) {
$settings['classname'] = ( ! empty( $settings['classname'] ) ) ? preg_replace( '/[^ A-Za-z0-9_-]*/', '', $settings['classname'] ) : '';
$settings['firstline'] = (int) ( ( ! empty( $settings['firstline'] ) ) ? $settings['firstline'] : $this->defaultsettings['firstline'] );
$settings['tabsize'] = (int) ( ( ! empty( $settings['tabsize'] ) ) ? $settings['tabsize'] : $this->defaultsettings['tabsize'] );
$settings['maxheight'] = (int) max( 0, ( $settings['maxheight'] ?? $this->defaultsettings['maxheight'] ) );
}

return $settings;
Expand Down