chore: take every dependency bump in one pass - #16
Merged
Conversation
Fourteen Dependabot PRs were open, all based on the pre-fix master where the clippy gate was already red, so their CI failures said nothing about the bumps themselves. Applying them together locally and testing against current master is both faster and more meaningful than fourteen rebase-and-wait cycles. candle-core 0.8.4 -> 0.11.0 candle-nn 0.8.4 -> 0.11.0 tokenizers 0.21.4 -> 0.23.1 safetensors 0.4.5 -> 0.8.0 rand 0.8 -> 0.9 rand_distr 0.4 -> 0.5 criterion 0.5 -> 0.8 clap, bytemuck, tokio -> latest patch actions/checkout 4 -> 7, github-script 7 -> 9, upload-artifact 4 -> 7, codecov-action 4 -> 7 Three mechanical migrations: - rand 0.9 removed StdRng::from_entropy in favour of from_os_rng, and renamed Rng::gen and gen_range to random and random_range. - safetensors 0.8 takes an owned Option for serialize's metadata argument rather than a reference. candle 0.11 needed no code changes at all, and the parity tests pass against it unchanged, so the upgrade does not move the numbers. Real 350M generation still produces correct Python. 102 tests pass, clippy clean at -D warnings.
GitMind PR Review{'pr_url': '#16', 'repo': 'Ayyankhan101/Transformer-In-Rust', 'pr_num': '16', 'title': 'chore: take every dependency bump in one pass', 'author': 'Ayyankhan101', 'additions': 299, 'deletions': 402, 'changed_files': 14, 'review': '## Summary\nAutomatic review could not be generated — please review the diff manually.\n\n## Issues\nNo significant issues found.\n\n## Verdict\n💬 NEEDS DISCUSSION\nThe automated review failed; human review required.'} Auto-generated by GitMind — AI-powered code analysis. |
This was referenced Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #1 #2 #3 #4 #5 #6 #7 #8 #9 #10 #11 #12 #13 #14.
All fourteen Dependabot PRs were based on
cb6f48f— the pre-fix master, wherecargo clippy --all-targets --all-features -- -D warningsalready exited 101. Every one ofthem showed Clippy, MSRV and all three test jobs failing, including #14, which changes
nothing but a GitHub Actions version. Those failures were inherited from the base, not
caused by the bumps, so their CI said nothing useful.
Applying them together against current master and testing locally is both faster and more
meaningful than fourteen rebase-and-wait cycles.
Migrations needed
Three, all mechanical:
rand0.9 removedStdRng::from_entropyin favour offrom_os_rng, and renamedRng::gen/gen_rangetorandom/random_range.safetensors0.8 takes an ownedOptionforserialize's metadata argument rather thana reference.
candle 0.11 needed no code changes at all — notable given it is the crate everything
here is built on.
Verification
tests/codegen_parity.rspasses unchanged against candle 0.11, so the upgrade does notmove the numbers. Real CodeGen-350M generation still produces correct Python.